Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvements for Cirque Pinnacle trackpads #17091

Merged
merged 8 commits into from
Jun 25, 2022
Merged

improvements for Cirque Pinnacle trackpads #17091

merged 8 commits into from
Jun 25, 2022

Conversation

Kriechi
Copy link
Contributor

@Kriechi Kriechi commented May 14, 2022 •
edited
Loading

Description

  • read Software Data Ready bit before actually reading data to avoid useless work
  • throttle data feed to 10ms by default, which is the fastest that Pinnacle supports
  • set RESET for Pinnacle on QMK pointing device driver init
  • first step towards relative mode (only data parsing for now)
  • cleanup unused register values when in absolute mode
  • added code comments and bit definitions for all registers and config options

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label May 14, 2022
@Kriechi Kriechi force-pushed the cirque-pinnacle-improvements branch 2 times, most recently from 79d6f24 to 8d2cda6 Compare May 15, 2022 09:04
@Kriechi Kriechi marked this pull request as ready for review May 15, 2022 09:17
@Kriechi Kriechi mentioned this pull request May 15, 2022
Closed
14 tasks
@Kriechi Kriechi force-pushed the cirque-pinnacle-improvements branch 2 times, most recently from c5df4fb to 7f2caa7 Compare May 16, 2022 19:50
dkao
dkao reviewed May 16, 2022
View reviewed changes
drivers/sensors/cirque_pinnacle.h Outdated Show resolved Hide resolved
drivers/sensors/cirque_pinnacle.c Outdated Show resolved Hide resolved
@Kriechi Kriechi force-pushed the cirque-pinnacle-improvements branch from 948cd56 to c1cf2e8 Compare May 17, 2022 19:29
@drashna drashna requested a review from a team May 20, 2022 05:30
@Kriechi
improvements for Cirque Pinnacle trackpads
1a024aa 
* read Software Data Ready bit before actually reading data to avoid useless work
* throttle data feed to 10ms by default, which is the fastest that Pinnacle supports
* set RESET for Pinnacle on QMK pointing device driver init
* first step towards relative mode (only data parsing for now)
* cleanup unused register values when in absolute mode
* added code comments and bit definitions for all registers and config options
@Kriechi
cirque: use the register defines
9926f09
@Kriechi
cirque: fail compilation if relative mode configured
a9ef396 
only partially implemented so far
@Kriechi
cirque: add valid data flag and do not process invalid data
b7e6fb3
@Kriechi
cirque: first do coordinates, then tap detection
1f2991c
@Kriechi
cirque: update config options and docs
afab84c
@Kriechi Kriechi force-pushed the cirque-pinnacle-improvements branch from c1cf2e8 to afab84c Compare June 22, 2022 20:12
KarlK90
KarlK90 requested changes Jun 23, 2022
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements to the code! 🙂 I have found some minor points in the code that need to be addressed but otherwise you have my approval.

drivers/sensors/cirque_pinnacle.c Outdated Show resolved Hide resolved
drivers/sensors/cirque_pinnacle_i2c.c Show resolved Hide resolved
drivers/sensors/cirque_pinnacle_spi.c Outdated Show resolved Hide resolved
docs/feature_pointing_device.md Outdated Show resolved Hide resolved
drivers/sensors/cirque_pinnacle.c Show resolved Hide resolved
drivers/sensors/cirque_pinnacle.h Outdated Show resolved Hide resolved
dkao
dkao suggested changes Jun 23, 2022
View reviewed changes
quantum/pointing_device_drivers.c Outdated Show resolved Hide resolved
@Kriechi Kriechi force-pushed the cirque-pinnacle-improvements branch from 78a44ea to dfb491b Compare June 25, 2022 14:46
@Kriechi
Copy link
Contributor Author

Kriechi commented Jun 25, 2022

@KarlK90 @dkao thanks for the reviews - should be all addressed now.

@KarlK90
Copy link
Member

KarlK90 commented Jun 25, 2022

@Kriechi thanks for addressing the review comments so fast, one point is left for me but other than that this is ready to go in.

@Kriechi
Copy link
Contributor Author

Kriechi commented Jun 25, 2022

Also addressed now - thanks!

KarlK90
KarlK90 approved these changes Jun 25, 2022
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! Merging.

@KarlK90 KarlK90 merged commit 01bc974 into qmk:develop Jun 25, 2022
@Kriechi Kriechi deleted the cirque-pinnacle-improvements branch June 25, 2022 20:51
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@Kriechi @zykrah
improvements for Cirque Pinnacle trackpads (qmk#17091)
dcb4273
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@Kriechi @nolanseaton
improvements for Cirque Pinnacle trackpads (qmk#17091)
0ab9043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkao dkao dkao requested changes

@KarlK90 KarlK90 KarlK90 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kriechi @KarlK90 @dkao @drashna @zvecr