Nebula12b

[yiancar]

Description

Successor of Nebula12.
Similar story as Nebula68b:)

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Issues Fixed or Closed by This PR

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[yiancar]

Ah yes nice!
One addition for the via code tho (in via.c) would be to scale brightness with MAX_BRIGHTNESS variable ;) I can do the PR if you like.

[drashna]

Ah yes nice! One addition for the via code tho (in via.c) would be to scale brightness with MAX_BRIGHTNESS variable ;) I can do the PR if you like.

Hmm, I'm not sure. In theory, even if you set the val to a higher value, it won't use past that. But I'm not sure that via will re-read and report that correctly? May need some testing/etc.

[yiancar]

Ah yes nice! One addition for the via code tho (in via.c) would be to scale brightness with MAX_BRIGHTNESS variable ;) I can do the PR if you like.

Hmm, I'm not sure. In theory, even if you set the val to a higher value, it won't use past that. But I'm not sure that via will re-read and report that correctly? May need some testing/etc.

Yes that is correct, essentially by doing a scale operation (as I had done here) the brightness dial will not jump around in via. Currently lets say max brightness is at 150, half the dial does nothing. You slide it to 100% and it will jump back to 50% after the refresh. I had quite a few users getting confused about that!

[yiancar]

Can we get this merged please?:)

[drashna]

Thanks!