Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is to scale the rgb_matrix brightness from and to VIA in case the max brightness set in firmware is not 255.
We have had confusion from users in an upcoming keyboard testing round about this.
VIA expects a value from 0 to 255. If the max brigthness in the firmware is set to below 255, any value send from VIA to the keyboard above the max firmware brightness will clip to the max firmware brightness. This results in the VIA slider to feel unresponsive.
As we are already doing something similar for Effect Speed I think this is appropriate.
EDIT:
This is also already done for backlight, so I cleaned it up a bit and did the same for rgblight
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist