Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale brigthness for VIA #17352

Merged
merged 3 commits into from
Jun 11, 2022
Merged

Conversation

yiancar
Copy link
Contributor

@yiancar yiancar commented Jun 10, 2022

This fix is to scale the rgb_matrix brightness from and to VIA in case the max brightness set in firmware is not 255.

We have had confusion from users in an upcoming keyboard testing round about this.

VIA expects a value from 0 to 255. If the max brigthness in the firmware is set to below 255, any value send from VIA to the keyboard above the max firmware brightness will clip to the max firmware brightness. This results in the VIA slider to feel unresponsive.

As we are already doing something similar for Effect Speed I think this is appropriate.

EDIT:
This is also already done for backlight, so I cleaned it up a bit and did the same for rgblight

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@yiancar yiancar changed the title Scale brigthness Scale brigthness for VIA Jun 10, 2022
@github-actions github-actions bot added the core label Jun 10, 2022
@tzarc tzarc changed the base branch from master to develop June 10, 2022 22:34
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swapped to develop due to core changes.

@tzarc tzarc requested a review from a team June 10, 2022 22:35
@drashna drashna merged commit 0fd08da into qmk:develop Jun 11, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
Co-authored-by: yiancar <yiancar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants