Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that rgb+via compiles in all cases #17355

Merged
merged 1 commit into from
Jun 11, 2022
Merged

Conversation

drashna
Copy link
Member

@drashna drashna commented Jun 11, 2022

Description

Needs defines from rgb engines to work. Added default/placeholders.

Ran multibuild to ensure all of the keymaps compile.

Types of Changes

  • Core
  • Bugfix

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@daskygit
Copy link
Member

Maybe these defaults should be set regardless of if VIA is enabled or not?

@drashna
Copy link
Member Author

drashna commented Jun 11, 2022

Maybe these defaults should be set regardless of if VIA is enabled or not?

They are. These preprocessors are pulled from rgblight.h and rgb_matrix.c respectively.

@drashna drashna merged commit 80034a8 into qmk:develop Jun 11, 2022
@drashna drashna deleted the fix/via_rgb branch June 11, 2022 05:01
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants