Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Boaty #17378

Merged
merged 13 commits into from
Nov 19, 2022
Merged

Support for Boaty #17378

merged 13 commits into from
Nov 19, 2022

Conversation

Jels02
Copy link
Contributor

@Jels02 Jels02 commented Jun 13, 2022

Description

Support for the Boaty - the boat shaped keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 13, 2022
drashna
drashna requested changes Jun 13, 2022
View reviewed changes
@Jels02
Change VendorID and image link
52b4a35 
Changed VendorID to be higher, and image is now hosted in imgur
@Jels02 Jels02 requested a review from drashna August 6, 2022 06:35
@Jels02 Jels02 marked this pull request as draft September 10, 2022 16:21
@Jels02 @drashna
Update keyboards/jels/boaty/readme.md
5de4845 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@Jels02 Jels02 marked this pull request as ready for review November 10, 2022 11:01
@Jels02 Jels02 requested a review from drashna November 10, 2022 11:02
@Jels02 Jels02 marked this pull request as draft November 15, 2022 08:16
@Jels02 Jels02 marked this pull request as ready for review November 15, 2022 08:44
@drashna drashna requested a review from a team November 15, 2022 18:30
fauxpark
fauxpark requested changes Nov 16, 2022
View reviewed changes
@Jels02 @fauxpark
Apply suggestions from code review
4143045 
Replace KC_NLCK with KC_NUM

Co-authored-by: Ryan <fauxpark@gmail.com>
@drashna drashna merged commit e165407 into qmk:master Nov 19, 2022
thystips pushed a commit to thystips/qmk_firmware that referenced this pull request Nov 24, 2022
@Jels02 @drashna
@fauxpark @thystips
[Keyboard] Add Boaty (qmk#17378)
ac66a3b 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Jels02 <joah@Joah-Big-PC.localdomain>
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@Jels02 @drashna
@fauxpark @ramonimbao
[Keyboard] Add Boaty (qmk#17378)
ac9e282 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Jels02 <joah@Joah-Big-PC.localdomain>
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@Jels02 @drashna
@fauxpark @elpekenin
[Keyboard] Add Boaty (qmk#17378)
068859e 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Jels02 <joah@Joah-Big-PC.localdomain>
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@Jels02 @drashna
@fauxpark @crembz
[Keyboard] Add Boaty (qmk#17378)
2eb07e6 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Jels02 <joah@Joah-Big-PC.localdomain>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jels02 @drashna @fauxpark