Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Mark GD32VF103 as ChibiOS-Contrib #17444

Merged
merged 1 commit into from
Jun 22, 2022
Merged

[Core] Mark GD32VF103 as ChibiOS-Contrib #17444

merged 1 commit into from
Jun 22, 2022

Conversation

KarlK90
Copy link
Member

@KarlK90 KarlK90 commented Jun 21, 2022 •
edited
Loading

Description

Mark all GD32VF103 targets as ChibiOS-Contrib sourced. This change will be necessary when ChibiOS/ChibiOS-Contrib#325 is merged as it aligns the naming to ChibiOS conventions.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jun 21, 2022
@tzarc
Copy link
Member

tzarc commented Jun 21, 2022

Could we just set USE_CHIBIOS_CONTRIB := yes in builddefs/mcu_selection.mk for the GD32VF103?

@drashna drashna requested a review from a team June 22, 2022 00:58
@KarlK90 KarlK90 force-pushed the feature/mark-gd32vf103-as-chibios-contrib branch from d0c30a9 to 5475929 Compare June 22, 2022 18:00
@KarlK90 KarlK90 force-pushed the feature/mark-gd32vf103-as-chibios-contrib branch from 5475929 to 26e1ef1 Compare June 22, 2022 18:02
@KarlK90
Copy link
Member Author

KarlK90 commented Jun 22, 2022

Could we just set USE_CHIBIOS_CONTRIB := yes in builddefs/mcu_selection.mk for the GD32VF103?

Good point, I actually did this in the platform.mk of ChibiOS as all the platform selection logic is done there. Let me know if this should be moved.

@KarlK90 KarlK90 marked this pull request as ready for review June 22, 2022 18:04
@KarlK90 KarlK90 requested a review from tzarc June 22, 2022 18:04
@tzarc tzarc merged commit 9aa9155 into qmk:develop Jun 22, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@KarlK90 @zykrah
[Core] Mark GD32VF103 as ChibiOS-Contrib (qmk#17444)
d9a53a5
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@KarlK90 @nolanseaton
[Core] Mark GD32VF103 as ChibiOS-Contrib (qmk#17444)
2c58664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KarlK90 @tzarc