Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(develop)Keychron Q2: Enable support for WL EEPROM Driver #17507

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

Jpe230
Copy link
Contributor

@Jpe230 Jpe230 commented Jun 30, 2022

Description

Enable WL EEPROM driver support for all the Keychron Q2 variants.

This PR removes the support for the (probably unused) I2c EEPROM but given that the famous playground branch doesn't have support for I2C EEPROM, I can make a safe assumption that there's no user with a board with an I2C EEPROM

All variants compile successfully (Test builds using the VIA keymap):

rev_0110:

Ψ Compiling keymap with make --jobs=1 keychron/q2/rev_0110:via


QMK Firmware 0.17.2
Making keychron/q2/rev_0110 with keymap via

arm-none-eabi-gcc (GNU Arm Embedded Toolchain 10.3-2021.10) 10.3.1 20210824 (release)
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Size before:
   text    data     bss     dec     hex filename
      0   40642       0   40642    9ec2 keychron_q2_rev_0110_via.bin


Size after:
   text    data     bss     dec     hex filename
      0   40642       0   40642    9ec2 keychron_q2_rev_0110_via.bin

Copying keychron_q2_rev_0110_via.bin to qmk_firmware folder                                         [OK]
(Firmware size check does not yet support STM32L433; skipping)

rev_0111:

Ψ Compiling keymap with make --jobs=1 keychron/q2/rev_0111:via


QMK Firmware 0.17.2
Making keychron/q2/rev_0111 with keymap via

arm-none-eabi-gcc (GNU Arm Embedded Toolchain 10.3-2021.10) 10.3.1 20210824 (release)
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Size before:
   text    data     bss     dec     hex filename
      0   41206       0   41206    a0f6 keychron_q2_rev_0111_via.bin


Size after:
   text    data     bss     dec     hex filename
      0   41206       0   41206    a0f6 keychron_q2_rev_0111_via.bin

Copying keychron_q2_rev_0111_via.bin to qmk_firmware folder                                         [OK]
(Firmware size check does not yet support STM32L433; skipping)

rev_0112:

Ψ Compiling keymap with make --jobs=1 keychron/q2/rev_0112:via


QMK Firmware 0.17.2
Making keychron/q2/rev_0112 with keymap via

arm-none-eabi-gcc (GNU Arm Embedded Toolchain 10.3-2021.10) 10.3.1 20210824 (release)
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Size before:
   text    data     bss     dec     hex filename
      0   40650       0   40650    9eca keychron_q2_rev_0112_via.bin


Size after:
   text    data     bss     dec     hex filename
      0   40650       0   40650    9eca keychron_q2_rev_0112_via.bin

Copying keychron_q2_rev_0112_via.bin to qmk_firmware folder                                         [OK]
(Firmware size check does not yet support STM32L433; skipping)

rev_0113:

Ψ Compiling keymap with make --jobs=1 keychron/q2/rev_0113:via


QMK Firmware 0.17.2
Making keychron/q2/rev_0113 with keymap via

arm-none-eabi-gcc (GNU Arm Embedded Toolchain 10.3-2021.10) 10.3.1 20210824 (release)
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Size before:
   text    data     bss     dec     hex filename
      0   41214       0   41214    a0fe keychron_q2_rev_0113_via.bin


Size after:
   text    data     bss     dec     hex filename
      0   41214       0   41214    a0fe keychron_q2_rev_0113_via.bin

Copying keychron_q2_rev_0113_via.bin to qmk_firmware folder                                         [OK]
(Firmware size check does not yet support STM32L433; skipping)

Tested all the compiled binaries with my rev_0111 board.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team June 30, 2022 02:10
@tzarc tzarc merged commit d206c17 into qmk:develop Jun 30, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@Jpe230 Jpe230 deleted the keychron_q2_wl branch July 27, 2022 16:58
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants