Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new keyboard #17513

Merged
merged 35 commits into from
Aug 20, 2022
Merged

add new keyboard #17513

merged 35 commits into from
Aug 20, 2022

Conversation

bojiguard
Copy link
Contributor

first upload fungo split keyboard

Description

Added new keyboard information.
keyboard name is "fungo".
only added keyboard directory.

new directory -> keyboards/fungo

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • none

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@bojiguard
add new keyboard
13e3385 
first upload fungo split keyboard
drashna
drashna reviewed Jul 1, 2022
View reviewed changes
keyboards/fungo/readme.md Outdated Show resolved Hide resolved
drashna
drashna requested changes Jul 1, 2022
View reviewed changes
keyboards/fungo/rev1/config.h Outdated Show resolved Hide resolved
keyboards/fungo/rev1/config.h Outdated Show resolved Hide resolved
keyboards/fungo/rev1/config.h Outdated Show resolved Hide resolved
keyboards/fungo/rev1/rules.mk Outdated Show resolved Hide resolved
keyboards/fungo/rev1/rules.mk Outdated Show resolved Hide resolved
keyboards/fungo/rules.mk Outdated Show resolved Hide resolved
keyboards/fungo/rules.mk Outdated Show resolved Hide resolved
keyboards/fungo/rules.mk Outdated Show resolved Hide resolved
@bojiguard
Copy link
Contributor Author

changed request

bojiguard
bojiguard commented Jul 1, 2022
View reviewed changes
Copy link
Contributor Author

@bojiguard bojiguard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all changed

drashna
drashna requested changes Jul 2, 2022
View reviewed changes
keyboards/fungo/readme.md Outdated Show resolved Hide resolved
keyboards/fungo/readme.md Show resolved Hide resolved
keyboards/fungo/rev1/rev1.h Outdated Show resolved Hide resolved
keyboards/fungo/rev1/rules.mk Outdated Show resolved Hide resolved
keyboards/fungo/rev1/rules.mk Outdated Show resolved Hide resolved
keyboards/fungo/rev1/rules.mk Outdated Show resolved Hide resolved
keyboards/fungo/rules.mk Outdated Show resolved Hide resolved
@bojiguard
Copy link
Contributor Author

all checked your review.

@bojiguard
Copy link
Contributor Author

Setting Handedness - change files

bojiguard
bojiguard commented Jul 6, 2022
View reviewed changes
Copy link
Contributor Author

@bojiguard bojiguard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there still a problem?

bojiguard
bojiguard commented Jul 9, 2022
View reviewed changes
Copy link
Contributor Author

@bojiguard bojiguard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change

@bojiguard bojiguard requested review from drashna and daskygit July 9, 2022 18:39
drashna
drashna reviewed Jul 11, 2022
View reviewed changes
keyboards/fungo/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/fungo/rev1/config.h Outdated Show resolved Hide resolved
keyboards/fungo/rev1/config.h Outdated Show resolved Hide resolved
keyboards/fungo/rev1/config.h Outdated Show resolved Hide resolved
keyboards/fungo/rev1/config.h Outdated Show resolved Hide resolved
bojiguard and others added 3 commits July 12, 2022 17:11
@bojiguard @drashna
Update keyboards/fungo/keymaps/default/keymap.c
b882bb5 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@bojiguard @drashna
Update keyboards/fungo/rev1/config.h
e01846b 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@bojiguard
change USB_POLLING_INTERVAL_MS
d4b95c6
drashna
drashna requested changes Jul 13, 2022
View reviewed changes
keyboards/fungo/rev1/config.h Outdated Show resolved Hide resolved
keyboards/fungo/rev1/config.h Outdated Show resolved Hide resolved
keyboards/fungo/rev1/config.h Outdated Show resolved Hide resolved
keyboards/fungo/rev1/config.h Outdated Show resolved Hide resolved
@bojiguard @drashna
Update keyboards/fungo/rev1/config.h
c99681a 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@bojiguard bojiguard requested a review from drashna July 15, 2022 08:16
drashna
drashna reviewed Jul 26, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a revision (eg rev1) really needed here? do you plan on having more revisions, later?

@bojiguard
Copy link
Contributor Author

bojiguard commented Jul 26, 2022 •
edited
Loading

Yes, I will try the first product and supplement it a little more.
I'm going to adjust the keyboard arrangement a little

@drashna drashna requested a review from a team July 26, 2022 21:22
fauxpark
fauxpark requested changes Aug 12, 2022
View reviewed changes
keyboards/fungo/readme.md Outdated Show resolved Hide resolved
keyboards/fungo/rev1/info.json Outdated Show resolved Hide resolved
keyboards/fungo/rev1/config.h
Comment on lines +23 to +32
/* USB Device descriptor parameter */
#define VENDOR_ID 0x5892
#define PRODUCT_ID 0x1233
#define DEVICE_VER 0x0001
#define MANUFACTURER Fungo
#define PRODUCT FungoSplit




Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* USB Device descriptor parameter */
#define VENDOR_ID 0x5892
#define PRODUCT_ID 0x1233
#define DEVICE_VER 0x0001
#define MANUFACTURER Fungo
#define PRODUCT FungoSplit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should I delete this item?
i dont understand.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already in info.json.

bojiguard and others added 2 commits August 15, 2022 19:20
@bojiguard @fauxpark
Update keyboards/fungo/readme.md
4a50d51 
Co-authored-by: Ryan <fauxpark@gmail.com>
@bojiguard @fauxpark
Update keyboards/fungo/rev1/info.json
57152cd 
Co-authored-by: Ryan <fauxpark@gmail.com>
@keyboard-magpie keyboard-magpie merged commit 5222cf7 into qmk:master Aug 20, 2022
@fauxpark fauxpark mentioned this pull request Aug 22, 2022
Merged
14 tasks
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@bojiguard @nolanseaton
add fungo keyboard (qmk#17513)
aeb280b 
by bojiguard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@drashna drashna drashna approved these changes

@keyboard-magpie keyboard-magpie keyboard-magpie approved these changes

@daskygit daskygit Awaiting requested review from daskygit

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bojiguard @drashna @fauxpark @keyboard-magpie @daskygit