Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also check /run/media/ for uf2 drives #17517

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Also check /run/media/ for uf2 drives #17517

merged 1 commit into from
Jun 30, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jun 30, 2022 •
edited
Loading

Description

Adds /run/media/<user>/ as a location to check, as /media does not exist on the machine im testing on.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team June 30, 2022 20:28
daskygit
daskygit approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@daskygit daskygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed this fix for Fedora.

@zvecr zvecr merged commit a98f698 into qmk:develop Jun 30, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@zvecr @zykrah
Also check /run/media/ for uf2 drives (qmk#17517)
6026194
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@zvecr @nolanseaton
Also check /run/media/ for uf2 drives (qmk#17517)
7d969a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daskygit daskygit daskygit approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core enhancement python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @fauxpark @daskygit