Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for keyquest keyboards #17667

Merged
merged 46 commits into from
Aug 6, 2022
Merged

Added support for keyquest keyboards #17667

merged 46 commits into from
Aug 6, 2022

Conversation

keyquesttech
Copy link

@keyquesttech keyquesttech commented Jul 13, 2022 •
edited
Loading

Added support for keyquest keyboards and "Enclave-1"

Description

I've added the "keyquest" folder which contains the enclave files to build firmware for Enclave-1

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 13, 2022
@keyquesttech keyquesttech mentioned this pull request Jul 13, 2022
Closed
6 tasks
drashna
drashna requested changes Jul 14, 2022
View reviewed changes
keyboards/keyquest/enclave/config.h Outdated Show resolved Hide resolved
keyboards/keyquest/enclave/config.h Outdated Show resolved Hide resolved
keyboards/keyquest/enclave/info.json Outdated Show resolved Hide resolved
keyboards/keyquest/enclave/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/keyquest/enclave/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/keyquest/enclave/keymaps/via/keymap.c Show resolved Hide resolved
keyboards/keyquest/enclave/readme.md Outdated Show resolved Hide resolved
fauxpark fix request
578fb20 
Fixed the issue on line 17
@keyquesttech
Copy link
Author

Sorry for the ping when it wasn't ready. im 99% this time it is ready.

@keyquesttech keyquesttech requested a review from fauxpark July 27, 2022 06:29
fauxpark
fauxpark requested changes Jul 27, 2022
View reviewed changes
keyboards/keyquest/enclave/rules.mk Outdated Show resolved Hide resolved
keyboards/keyquest/enclave/rules.mk Outdated Show resolved Hide resolved
keyboards/keyquest/enclave/info.json Show resolved Hide resolved
keyboards/keyquest/enclave/config.h Outdated Show resolved Hide resolved
@keyquesttech keyquesttech requested a review from fauxpark July 27, 2022 06:46
@keyquesttech
Copy link
Author

Hopefully its ok now 🙄

fauxpark
fauxpark requested changes Jul 27, 2022
View reviewed changes
keyboards/keyquest/enclave/rules.mk Outdated Show resolved Hide resolved
@keyquesttech keyquesttech requested a review from fauxpark July 27, 2022 07:30
@keyquesttech
Copy link
Author

Fixed issue with the period. Sorry for missing that 😓

@drashna drashna requested a review from a team July 27, 2022 15:01
@keyquesttech
Copy link
Author

keyquesttech commented Aug 6, 2022 •
edited
Loading

Hello @fauxpark, could you check the changes , i'm confident this time it's fine. Thanks for your time.

@tzarc tzarc merged commit 07fc375 into qmk:master Aug 6, 2022
@keyquesttech keyquesttech mentioned this pull request Aug 6, 2022
Merged
6 tasks
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@keyquesttech @Mathiaszmrga @imhoffman
Added support for keyquest keyboards (qmk#17667)
bce6767 
Co-authored-by: Mathiaszmrga <mmoragrega@centro.edu.mx>
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@keyquesttech @Mathiaszmrga @nolanseaton
Added support for keyquest keyboards (qmk#17667)
9caba9d 
Co-authored-by: Mathiaszmrga <mmoragrega@centro.edu.mx>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@keyquesttech @Mathiaszmrga @drashna @tzarc @fauxpark