Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation error in Ploopy Nano maddie keymap #17733

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Fix compilation error in Ploopy Nano maddie keymap #17733

merged 1 commit into from
Jul 22, 2022

Conversation

aidalgol
Copy link

@aidalgol aidalgol commented Jul 20, 2022 •
edited
Loading

Description

Followup to #17213 to fix compilation error.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation
  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@hexadecatrienoic @drashna @fauxpark @dhorlick

zvecr
zvecr reviewed Jul 21, 2022
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hexadecatrienoic will need to sign off on the change per contribution guidelines.

@hexadecatrienoic
Copy link

approved, thanks for keeping this map updated!

@zvecr zvecr merged commit de10784 into qmk:master Jul 22, 2022
smocky pushed a commit to smocky/qmk_firmware that referenced this pull request Jul 22, 2022
@aidalgol @smocky
Fix compilation error in Ploopy Nano maddie keymap (qmk#17733)
fe85ebf
Haruki pushed a commit to Haruki/qmk_firmware that referenced this pull request Jul 23, 2022
@aidalgol @Haruki
Fix compilation error in Ploopy Nano maddie keymap (qmk#17733)
dbcef06
schattenbrot pushed a commit to schattenbrot/qmk_firmware that referenced this pull request Aug 2, 2022
@aidalgol @schattenbrot
Fix compilation error in Ploopy Nano maddie keymap (qmk#17733)
2fa879d
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@aidalgol @imhoffman
Fix compilation error in Ploopy Nano maddie keymap (qmk#17733)
06b5743
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@aidalgol @nolanseaton
Fix compilation error in Ploopy Nano maddie keymap (qmk#17733)
03fc239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr left review comments

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

@dhorlick dhorlick dhorlick approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aidalgol @hexadecatrienoic @dhorlick @drashna @fauxpark @zvecr