Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create generic Pointing Device Pin defines #17776

Merged
merged 4 commits into from
Aug 12, 2022

Conversation

drashna
Copy link
Member

@drashna drashna commented Jul 24, 2022

Description

Create default defines for pin configs, so that switching between sensors is easier.

Types of Changes

  • Core
  • Enhancement/optimization
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team July 24, 2022 19:17
@drashna drashna force-pushed the pointing/pin_defines branch 2 times, most recently from e4926e4 to effbff9 Compare July 30, 2022 20:46
@drashna drashna merged commit ccdba43 into qmk:develop Aug 12, 2022
@drashna drashna deleted the pointing/pin_defines branch August 12, 2022 23:22
@drashna drashna mentioned this pull request Aug 27, 2022
14 tasks
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants