Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Fix ChibiOS i2c_master error codes #17808

Merged
merged 1 commit into from
Jul 28, 2022
Merged

[Core] Fix ChibiOS i2c_master error codes #17808

merged 1 commit into from
Jul 28, 2022

Conversation

KarlK90
Copy link
Member

@KarlK90 KarlK90 commented Jul 26, 2022

Description

msg_t is MSG_OK in the success case and either MSG_RESET or MSG_TIMEOUT in case of errors. So actually use them in the comparison.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@KarlK90
ChibiOS: use correct status codes in i2c_master.c
9d032c8 
msg_t is MSG_OK in the success case and either MSG_RESET or MSG_TIMEOUT
in case of errors. So actually use them in the comparison.
@github-actions github-actions bot added the core label Jul 26, 2022
@KarlK90 KarlK90 requested review from a team, sigprof and tzarc July 26, 2022 21:21
@zvecr zvecr merged commit 157ea96 into qmk:develop Jul 28, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@KarlK90 @nolanseaton
ChibiOS: use correct status codes in i2c_master.c (qmk#17808)
67ae809 
msg_t is MSG_OK in the success case and either MSG_RESET or MSG_TIMEOUT
in case of errors. So actually use them in the comparison.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@sigprof sigprof Awaiting requested review from sigprof

@tzarc tzarc Awaiting requested review from tzarc

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KarlK90 @zvecr