Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] RP2040 disable PIO IRQs on serial timeout #17839

Merged
merged 1 commit into from
Jul 29, 2022
Merged

[Core] RP2040 disable PIO IRQs on serial timeout #17839

merged 1 commit into from
Jul 29, 2022

Conversation

KarlK90
Copy link
Member

@KarlK90 KarlK90 commented Jul 29, 2022

Description

In case the sending or receiving timeout we don't want the IRQs to fire anymore as the waiting thread has already been woken.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@KarlK90
RP2040: serial pio disable IRQs on timeout
9a4c966 
In case the sending or receiving timesout we don't want the IRQs to
fire anymore as the waiting thread has already been woken.
@KarlK90 KarlK90 added the bug label Jul 29, 2022
@github-actions github-actions bot added the core label Jul 29, 2022
@KarlK90 KarlK90 changed the title [Core] RP2040: disable IRQs on timeout [Core] RP2040 disable PIO IRQs on serial timeout Jul 29, 2022
@KarlK90 KarlK90 requested review from daskygit and a team July 29, 2022 15:28
@KarlK90 KarlK90 merged commit a204523 into qmk:develop Jul 29, 2022
@KarlK90 KarlK90 deleted the fix/rp2040-serial-vendor-irq-disable branch July 29, 2022 18:13
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@KarlK90 @nolanseaton
[Core] RP2040 disable PIO IRQs on serial timeout (qmk#17839)
fc6bc1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daskygit daskygit daskygit approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KarlK90 @daskygit