Move keyboard USB IDs and strings to data driven: K #17846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
noroadsleft
requested changes
Jul 31, 2022
There was a problem hiding this comment.
Some general notes:
- Some of the KBDfans boards use
"manufacturer": "KBDfans", and others are set to"manufacturer": "KBDFans"with a capital F. - Most boards with multiple revisions are now set to specify the revision in
"keyboard_name", which I think is a good change - but the Suihankey by kakunpc does not. Is that deliberate? keyboards/keyboardio/model01/config.hstill has the USB strings; they haven't been removed in the conversion to data-driven config.
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
I tried to keep whatever was there originally, and made tweaks as I thought necessary. I'm not too bothered by it; the only thing I don't touch is the VID/PID as that will break VIA. |
noroadsleft
approved these changes
Jul 31, 2022
|
I looks like some of the kdbfans boards were not done (e.g. kbdfans/kbd75). Was this intentional? |
|
Yes: #16481 |
keyboard-magpie
approved these changes
Aug 3, 2022
imhoffman
pushed a commit
to imhoffman/qmk_firmware
that referenced
this pull request
Aug 20, 2022
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous PR: #17837
Types of Changes
Issues Fixed or Closed by This PR
Checklist