Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ST7735 driver to Quantum Painter #17848

Merged
merged 3 commits into from
Aug 1, 2022
Merged

Add ST7735 driver to Quantum Painter #17848

merged 3 commits into from
Aug 1, 2022

Conversation

infinityis
Copy link
Contributor

Using ST7789 as a template, I've added an ST7735 driver to Quantum Painter

Description

The ST7735 driver code is very similar to the existing ST7789 driver code, with a few exceptions:

  • The list of ST7735-specific opcodes in qp_st7735_opcodes.h are different (albeit currently unused by QP)
  • The automatic viewport offsets are different. Testing was done using a 80x160 ST7735 display, for which the automatic offsets were determined experimentally for each rotation option.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team July 31, 2022 00:02
@drashna drashna merged commit 2bdd73f into qmk:develop Aug 1, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants