Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YaMseK: yet another modular split ergonomic keyboard #17902

Closed
wants to merge 19 commits into from
Closed

YaMseK: yet another modular split ergonomic keyboard #17902

wants to merge 19 commits into from

Conversation

JohSchneider
Copy link
Contributor

created waaay back in 2017, based on/inspired by dactyl end ergodox like keyboards: curved ortholinear layout, with one MCU connected over TRRS to another half with an I2C-portexpander

a couple of small pcbs where designed around SMD chips -
to be usable as modular platform for putting together similar keyboards:
breakouts for ioexpanders, i2c buffer chips, ...

see the hackaday.io project page for futher build-instructions (to be updated...)

at the time the MCU of choice is/was a A-Star 32U4 Micro chosen for its diminutive size - but now that there are similar boards with an RP2040 out in the wild - and the support for these is slowly coming to QMK... :-D

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@JohSchneider JohSchneider force-pushed the yamsek_2022 branch 2 times, most recently from 1b4d5de to bd610c6 Compare August 4, 2022 12:50
@JohSchneider JohSchneider marked this pull request as ready for review October 29, 2022 15:46
@JohSchneider
Copy link
Contributor Author

this PR was waiting on #18178 which was merged... but..
@drashna what's the background that lead to the revert PR #18709 ? :-S

@drashna
Copy link
Member

drashna commented Oct 31, 2022

Basically, re-initing everything isn't the proper way to handle this. There are a couple of boards using the mcp code that can be used as examples to better handle detection, etc.

@JohSchneider
Copy link
Contributor Author

JohSchneider commented Oct 31, 2022 •
edited
Loading

There are a couple of boards using the mcp code

sadly there are multiple versions... the ergodox-derived ones do their own i2c handling (and reset everything everytime?), and only very few actually seem to use drivers/gpio/mcp23018

as evident by who uses init_mcp23018 == ergodox family; vs. drivers/gpio/mcp23018::mcp23018_init

did you have any specific "good examples" in mind?

@drashna
Copy link
Member

drashna commented Nov 8, 2022

The ergodone uses /drivers/gpio/mcp23018.c for the I/O expander code, and has detection/error handling.

@JohSchneider JohSchneider force-pushed the yamsek_2022 branch 3 times, most recently from 067e800 to 8278595 Compare December 10, 2022 07:59
@github-actions github-actions bot added the core label Dec 10, 2022
@JohSchneider
Copy link
Contributor Author

Note: the [core] I2C_PAL_MODE addition has it's own PR: #19286

@JohSchneider
Copy link
Contributor Author

ok, compared the MCP23018 handling to how it's done in the ergodone (thanks for the hint)
seems pretty similar: calling mcp23018_init only once during startup; and as soon as i2c-errors accumulate, do a "weak" reinitialization by calling mcp23018_set_config

what else would be missing for this PR to be merged? (-:

@KarlK90 KarlK90 mentioned this pull request Dec 11, 2022
Closed
14 tasks
drashna
drashna requested changes Jan 1, 2023
View reviewed changes
keyboards/handwired/yamsek/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/yamsek/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/yamsek/yamsek.h Outdated Show resolved Hide resolved
keyboards/handwired/yamsek/keymaps/default/keymap.c Show resolved Hide resolved
waffle87
waffle87 requested changes Jan 14, 2023
View reviewed changes
keyboards/handwired/yamsek/atmega32u4/config.h Show resolved Hide resolved
keyboards/handwired/yamsek/atmega32u4/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/yamsek/config.h Outdated Show resolved Hide resolved
keyboards/handwired/yamsek/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/yamsek/keymaps/default/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/yamsek/rp2040/rules.mk Outdated Show resolved Hide resolved
@drashna drashna added the awaiting_pr Relies on another PR to be merged first label Jan 15, 2023
@JohSchneider
Copy link
Contributor Author

thanks for the info.json related hints : )
see last commit - comme ca?

@JohSchneider JohSchneider force-pushed the yamsek_2022 branch 2 times, most recently from a9e293d to 74137d8 Compare February 11, 2023 17:31
drashna
drashna requested changes Feb 17, 2023
View reviewed changes
keyboards/handwired/yamsek/config.h Outdated Show resolved Hide resolved
keyboards/handwired/yamsek/config.h Outdated Show resolved Hide resolved
keyboards/handwired/yamsek/rp2040/config.h Outdated Show resolved Hide resolved
keyboards/handwired/yamsek/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/yamsek/yamsek.c Show resolved Hide resolved
platforms/chibios/chibios_config.h Outdated Show resolved Hide resolved
@JohSchneider JohSchneider removed the request for review from waffle87 February 20, 2023 18:01
@JohSchneider
Copy link
Contributor Author

rebase onto develop

Q: is there anything i can or need to do to help this PR get merged? :-)

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Nov 15, 2023
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Dec 31, 2023
JohSchneider and others added 19 commits December 31, 2023 07:57
@JohSchneider
YaMseK: current working state
2c530be 
sans 'VIAL' and the piromoni trackball...
also only the polulu-a-star/atmega32u4 - rp2040 to follow

Signed-off-by: Johannes Schneider <JohSchneider@googlemail.com>
@JohSchneider
YaMseK: fix keyboard layout
6858cb2 
aligning the LAYOUT macro with how the keys are layed out physically
@JohSchneider
YaMseK: cleanup
683fd6e
@JohSchneider
YaMseK: add rp2040 support
0b29136
@JohSchneider
YaMseK: minor cleanup
78e385e
@JohSchneider
YaMseK: build fixes
31537bb
@JohSchneider @drashna
update feature switches
bd8da89 
with upstream defaults in mind, some can be dropped

Co-authored-by: Drashna Jaelre <drashna@live.com>
@JohSchneider @drashna
remove unnecessary if-defed include
0231015 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@JohSchneider
YaMseK: realign keymap.c with yamsek.h
b53e20d
@JohSchneider
yamsek: config cleanup
31bae58
@JohSchneider
yamsek: convert to info.json
5f77f33
@JohSchneider @drashna
Apply suggestions from code review
ae2d759 
fixing includes, removing redundant defines, etc

Co-authored-by: Drashna Jaelre <drashna@live.com>
@JohSchneider
yamsek: fix compile errors after rebase onto develop
f1744c0 
Signed-off-by: Johannes Schneider <JohSchneider@googlemail.com>
@JohSchneider @sigprof
Apply suggestions from code review
46bb191 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
Signed-off-by: Johannes Schneider <JohSchneider@googlemail.com>
@JohSchneider
update keymap in info.json
396773f 
drop old-style keymap definition in favor of info.json entry

Signed-off-by: Johannes Schneider <JohSchneider@googlemail.com>
@JohSchneider
yamsek: fix key positions in info.json
240573d
@JohSchneider
yamsek: fix lint warning
f524aea 
'Layout "LAYOUT" is offset on Y axis by 1'
@JohSchneider @sigprof
Update keyboards/handwired/yamsek/info.json
5f68a86 
fix it to match the keymap

Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@JohSchneider
fix minor LINT error in the rules.mk
84bd503
@JohSchneider
Copy link
Contributor Author

no changes, just a rebase onto origin/master

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jan 1, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Feb 16, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@precondition precondition precondition left review comments

@sigprof sigprof sigprof requested changes

@drashna drashna Awaiting requested review from drashna

@waffle87 waffle87 Awaiting requested review from waffle87

Assignees
No one assigned
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JohSchneider @drashna @sigprof @precondition @waffle87