Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LT_ZCAR in place of LT_PLUS for modded kc definitions of keymap_lithuanian_qwerty.h #18000

Merged
merged 1 commit into from
Aug 13, 2022
Merged

Use LT_ZCAR in place of LT_PLUS for modded kc definitions of keymap_lithuanian_qwerty.h #18000

merged 1 commit into from
Aug 13, 2022

Conversation

precondition
Copy link
Contributor

@precondition precondition commented Aug 11, 2022 •
edited
Loading

Description

The QWERTY Lithuanian '+' (LT_PLUS) is on S(ALGR(KC_EQL)), and yet LT_PLUS was used to compose the keycode aliases for other modded keycodes involving KC_EQL, when LT_ZCAR would have been more appropriate.

The file even contained a definition of LT_PLUS in terms of itself:

#define LT_PLUS S(ALGR(LT_PLUS)) // +

screenshot of gkbd --layout lt

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Aug 11, 2022
@precondition precondition mentioned this pull request Aug 11, 2022
Merged
12 tasks
@precondition
Copy link
Contributor Author

That's a nice PR identifier/number

@drashna drashna requested review from fauxpark and a team August 12, 2022 02:28
@fauxpark fauxpark requested a review from a team August 12, 2022 23:03
@drashna drashna merged commit b4fbb34 into qmk:develop Aug 13, 2022
@precondition precondition deleted the lithuanian_qwerty_fix branch August 13, 2022 04:05
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@precondition @nolanseaton
Use LT_ZCAR in place of LT_PLUS for modded kc definitions (qmk#18000)
8d1158e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@precondition @drashna @fauxpark