Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KR_DQUO S(KR_COLN) → KR_DQUO S(KR_QUOT) in keymap_korean.h #18011

Merged
merged 1 commit into from
Aug 13, 2022

Conversation

precondition
Copy link
Contributor

Description

KR_DQUO was incorrectly defined as shift + KR_COLN.

diff --git a/quantum/keymap_extras/keymap_korean.h b/quantum/keymap_extras/keymap_korean.h
index 74be122dad..3d41a98b88 100644
--- a/quantum/keymap_extras/keymap_korean.h
+++ b/quantum/keymap_extras/keymap_korean.h
@@ -121,7 +121,7 @@
 #define KR_PIPE S(KR_WON)  // |
 // Row 3
 #define KR_COLN S(KR_SCLN) // :
-#define KR_DQUO S(KR_COLN) // "
+#define KR_DQUO S(KR_QUOT) // "
 // Row 4
 #define KR_LABK S(KR_COMM) // <
 #define KR_RABK S(KR_DOT)  // >

For reference:

75:#define KR_QUOT KC_QUOT // '

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Aug 12, 2022
@precondition precondition changed the title KR_DQUO S(KR_COLN) → KR_DQUO S(KR_QUOT) KR_DQUO S(KR_COLN) → KR_DQUO S(KR_QUOT) in keymap_korean.h Aug 12, 2022
@fauxpark fauxpark requested a review from a team August 12, 2022 23:02
@drashna drashna merged commit 4ff39b5 into qmk:develop Aug 13, 2022
@precondition precondition deleted the fix_KR_DQUO branch August 13, 2022 04:07
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants