Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ANSI ASCII art and fix comments for LT_COLN and LT_UNDS in keymap_lithuanian_qwerty.h #18028

Merged
merged 1 commit into from
Aug 14, 2022
Merged

Use ANSI ASCII art and fix comments for LT_COLN and LT_UNDS in keymap_lithuanian_qwerty.h #18028

merged 1 commit into from
Aug 14, 2022

Conversation

precondition
Copy link
Contributor

@precondition precondition commented Aug 13, 2022 •
edited
Loading

Description

Unlike other Lithuanian, the QWERTY/"numeric" version evolved from the US ANSI keyboard layout and makes no meaningful distinction between KC_BSLS, KC_NUHS, or KC_NUBS.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization (as in better comments)
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Aug 13, 2022
@drashna drashna requested a review from a team August 14, 2022 00:33
@drashna drashna merged commit 2c3b447 into qmk:develop Aug 14, 2022
@precondition precondition deleted the fix_keymap_lithuanian_qwerty branch August 14, 2022 04:06
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@precondition @nolanseaton
Use ANSI ASCII art and fix comments for LT_COLN and LT_UNDS in keymap…
7219e34 
…_lithuanian_qwerty.h (qmk#18028)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@precondition @drashna @fauxpark