Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent USB peripheral fault when restarting USB on WB32 MCUs #18058

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Prevent USB peripheral fault when restarting USB on WB32 MCUs #18058

merged 1 commit into from
Sep 2, 2022

Conversation

itarze
Copy link
Contributor

@itarze itarze commented Aug 15, 2022 •
edited
Loading

Description

Add some default definitions for WB32 MCU.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Aug 15, 2022
@drashna drashna requested a review from a team August 15, 2022 17:53
@tzarc tzarc requested a review from a team August 25, 2022 11:25
@tzarc tzarc added the bug label Aug 25, 2022
@tzarc tzarc changed the title Add some default definitions. Prevent USB peripheral fault when restarting USB on WB32 MCUs Aug 25, 2022
@itarze
Copy link
Contributor Author

itarze commented Aug 27, 2022

Can it be merged to the master branch?

@drashna drashna changed the base branch from develop to master August 28, 2022 17:06
@drashna drashna changed the base branch from master to develop August 28, 2022 17:07
drashna
drashna approved these changes Aug 28, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it could target master, but in general, core changes like this, we like to target develop in case there are issues with the change.

@itarze itarze mentioned this pull request Sep 2, 2022
Merged
14 tasks
@drashna drashna merged commit b5a52b4 into qmk:develop Sep 2, 2022
@itarze itarze deleted the ita branch September 2, 2022 09:16
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@itarze @ramonimbao
Prevent USB peripheral fault when restarting USB on WB32 MCUs (qmk#18058
658518b 
)

Co-authored-by: Joy <chang.li@westberrytech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itarze @drashna @tzarc