Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup F4xx wear-leveling bootloader check #18102

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Fixup F4xx wear-leveling bootloader check #18102

merged 1 commit into from
Aug 19, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Aug 19, 2022 •
edited
Loading

Description

Mistakenly checking against BOOTLOADER_STM32 instead of BOOTLOADER_STM32_DFU.
Thanks @Gondolindrim for confirmation of fix.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team August 19, 2022 04:13
@Gondolindrim
Copy link
Contributor

Tested on a F401 board working fine

@zvecr zvecr merged commit 1eac095 into qmk:develop Aug 19, 2022
@tzarc tzarc deleted the wear-leveling-f4xx-bugfix branch August 19, 2022 04:21
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@tzarc @nolanseaton
Use the correct bootloader definition. (qmk#18102)
93f921d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzarc @Gondolindrim @zvecr