Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add boardsource/lulu RP2040 support #18200

Merged
merged 5 commits into from
Aug 30, 2022
Merged

Add boardsource/lulu RP2040 support #18200

merged 5 commits into from
Aug 30, 2022

Conversation

waffle87
Copy link
Member

Description

Adds support for the PCBs sold in group buy.

Types of Changes

  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboard-magpie
keyboard-magpie requested changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@keyboard-magpie keyboard-magpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor semantics suggestions for readme.md otherwise LGTM

keyboards/boardsource/lulu/readme.md Outdated Show resolved Hide resolved
@keyboard-magpie
Copy link
Contributor

Oh. Still failing lint...

@waffle87
update readme & switch to dev board
e9c470e 
as avr pcb variant is designed for pro micro footprint
drashna
drashna reviewed Aug 29, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KeyError: 'matrix_size'

Specific lint error.

@drashna drashna requested a review from a team August 30, 2022 03:04
@keyboard-magpie keyboard-magpie merged commit 035e7fd into qmk:master Aug 30, 2022
@waffle87 waffle87 deleted the lulu_rp2040 branch August 30, 2022 07:20
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@waffle87 @nolanseaton
Add boardsource/lulu RP2040 support (qmk#18200)
ee38c67 
by waffle87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@keyboard-magpie keyboard-magpie keyboard-magpie approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waffle87 @keyboard-magpie @drashna