Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefinition of MIN is avoided in midi.c #18203

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

3araht
Copy link
Contributor

@3araht 3araht commented Aug 29, 2022

Description

It showed an error when tmk_core/protocol/midi/midi.c was included.

Error:

Compiling: tmk_core/protocol/midi/midi.c                                                           tmk_core/protocol/midi/midi.c:22: error: "MIN" redefined [-Werror]
 #define MIN(x, y) (((x) < (y)) ? (x) : (y))

The same method applied to rgblight.c, audio.h, vilocikey.c, color.c and util.h is used to solve it.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Aug 29, 2022
@drashna drashna requested a review from a team August 29, 2022 16:35
@drashna drashna merged commit f04336f into qmk:master Aug 29, 2022
@3araht 3araht deleted the avoid_redefine_min_in_midi_c branch August 30, 2022 11:02
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants