Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keychron q5 #18283

Merged
merged 21 commits into from
Nov 20, 2022
Merged

Keychron q5 #18283

merged 21 commits into from
Nov 20, 2022

Conversation

KeychronMacro
Copy link
Contributor

Add new keyboard q5 which contains four sub versions.

Description

  • Add keyboard rev_0150, ansi version of q5.
  • Add keyboard rev_0151, ansi version of q5 and enable encoder ec11.
  • Add keyboard rev_0152, iso version of q5.
  • Add keyboard rev_0153, iso version of q5 and enable encoder ec11.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 6, 2022
zvecr
zvecr requested changes Sep 6, 2022
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ENCODER_MAP_ENABLE should only be set at the keymap level

@KeychronMacro KeychronMacro requested a review from zvecr September 6, 2022 06:19
zvecr
zvecr requested changes Sep 6, 2022
View reviewed changes
@zvecr zvecr requested a review from a team September 6, 2022 09:15
KeychronMacro and others added 8 commits September 6, 2022 17:16
@KeychronMacro @zvecr
Update keyboards/keychron/q5/rev_0153/rules.mk
f08777d 
Co-authored-by: Joel Challis <git@zvecr.com>
@KeychronMacro @zvecr
Update keyboards/keychron/q5/config.h
2ff576c 
Co-authored-by: Joel Challis <git@zvecr.com>
@KeychronMacro @zvecr
Update keyboards/keychron/q5/matrix.c
394c86c 
Co-authored-by: Joel Challis <git@zvecr.com>
@KeychronMacro @zvecr
Update keyboards/keychron/q5/halconf.h
c1044af 
Co-authored-by: Joel Challis <git@zvecr.com>
@KeychronMacro @zvecr
Update keyboards/keychron/q5/matrix.c
9e4437d 
Co-authored-by: Joel Challis <git@zvecr.com>
@galican
Update readme.md of q5
a3f3053
@galican
Update readme.md
97375fa
@galican
Update matrix.c
daa1efe
@KeychronMacro KeychronMacro requested a review from zvecr September 10, 2022 13:15
drashna
drashna reviewed Sep 14, 2022
View reviewed changes
KeychronMacro and others added 2 commits September 15, 2022 09:06
@KeychronMacro @drashna
Update keyboards/keychron/q5/q5.c
50f121b 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@galican
Update readme.md
1447cf6
@drashna drashna requested a review from a team September 20, 2022 01:06
@keychron-dev
Copy link

@zvecr do you have time to check this one? thanks

@drashna drashna merged commit 0f6a4ed into qmk:master Nov 20, 2022
This was referenced Nov 21, 2022
Merged
Merged
thystips pushed a commit to thystips/qmk_firmware that referenced this pull request Nov 24, 2022
@KeychronMacro @zvecr
@drashna @thystips
[Keyboard] Keychron Q5 (qmk#18283)
143ff67 
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@KeychronMacro @zvecr
@drashna @ramonimbao
[Keyboard] Keychron Q5 (qmk#18283)
e39ee71 
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@KeychronMacro @zvecr
@drashna @elpekenin
[Keyboard] Keychron Q5 (qmk#18283)
a709ce7 
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
@KeychronMacro KeychronMacro deleted the keychron-q5 branch December 12, 2022 03:04
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@KeychronMacro @zvecr
@drashna @crembz
[Keyboard] Keychron Q5 (qmk#18283)
92f5bc4 
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KeychronMacro @keychron-dev @drashna @fauxpark @zvecr @galican