-
-
Notifications
You must be signed in to change notification settings - Fork 39.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keychron q6 #18288
Keychron q6 #18288
Conversation
Hi, just bought a q6 and was wandering what the status of this pr is? |
Co-authored-by: Drashna Jaelre <drashna@live.com>
Is there anything actually blocking this merge, or are we just waiting on someone to push the button at this point? |
We're in discussion to help simplify long-term maintenance of the Keychron submissions. Bear with us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure, these layouts (layout macro names) are correct? The Q6 is Fullsize (+F13) + 4 Buttons above the Numpad. Does not seem to be a standard layout you can find here: https://github.com/qmk/qmk_firmware/tree/master/layouts/default
Here is an image of the non-knob version (no F13): https://www.keychron.com/pages/keychron-q6-keycap-size
I can confirm that the Q6 is not a TKL layout. It has the layout shown in your link. It's basically fullsize_ISO/ansi with 4 additional keys above the numpad. |
a22a7d1
to
cc7d5c9
Compare
keyboards/keychron/q6/q6.c
Outdated
return false; | ||
} | ||
switch (keycode) { | ||
# ifdef RGB_MATRIX_ENABLE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RGB_MATRIX_ENABLE
is already checked in line 42
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed, thanks.
I just flashed a build of this firmware (VIA version) on a Q6 ISO Knob. Now I am unable to remap the rotation of the encoder. Remapping of pressing the knob works, though. Edit I was using this keymap: https://cdn.shopify.com/s/files/1/0059/0630/1017/files/Q6_UK_ISO_Knob_V1.2.json.zip |
I was able to fix this by adding a proper definition of the encoder to the via json: |
This was because they were using the |
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
can this be merged now? |
Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com>
Add new keyboard q6 which contains four sub versions.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist