-
-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added analog support for WB32 MCU. #18289
Conversation
No one review ? |
This is one of the areas that I'm not really comfortable with, so I haven't reviewed it. However, the people that are more familiar with this section haven't had a chance to get to it yet. |
Just waiting on CI to confirm. |
Ok, thank you very much for your review. |
Please apply this patch so the onekey variants work -- we don't have write access to the PR. |
Ok. |
I can see you're trying to fix all of the onekey keymaps -- for now there's no need, just the analog would have sufficed for the context of this PR. It's great that the I2C ones are now sorted as well! If you wish to create a followup PR in the future to fix others that's fine, but analog was really the only concern at this point. We'll generally check the failures and ignore them if they're unrelated to the PR's changes. |
Can I handle all the onekey keymaps in this PR at once? |
Sure, let me know when you're happy and I'll re-review. |
@tzarc All the work items have been passed, you can review them now. |
Co-authored-by: Joy <chang.li@westberrytech.com>
Description
As the title.
Types of Changes
Issues Fixed or Closed by This PR
Checklist