Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added analog support for WB32 MCU. #18289

Merged
merged 5 commits into from
Nov 1, 2022
Merged

Added analog support for WB32 MCU. #18289

merged 5 commits into from
Nov 1, 2022

Conversation

itarze
Copy link
Contributor

@itarze itarze commented Sep 6, 2022

Description

As the title.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Sep 6, 2022
@drashna drashna requested a review from a team September 14, 2022 16:00
@itarze
Copy link
Contributor Author

itarze commented Oct 15, 2022

No one review ?

@drashna
Copy link
Member

drashna commented Oct 25, 2022

This is one of the areas that I'm not really comfortable with, so I haven't reviewed it.

However, the people that are more familiar with this section haven't had a chance to get to it yet.

@drashna drashna requested a review from a team October 26, 2022 19:37
tzarc
tzarc previously approved these changes Oct 31, 2022
@tzarc
Copy link
Member

tzarc commented Oct 31, 2022

Just waiting on CI to confirm.

@itarze
Copy link
Contributor Author

itarze commented Oct 31, 2022

Ok, thank you very much for your review.

@tzarc
Copy link
Member

tzarc commented Oct 31, 2022

Please apply this patch so the onekey variants work -- we don't have write access to the PR.

onekey-analog.patch.txt

@itarze
Copy link
Contributor Author

itarze commented Oct 31, 2022

Ok.

@tzarc tzarc dismissed their stale review October 31, 2022 02:56

waiting on analog to be added to onekey

@tzarc
Copy link
Member

tzarc commented Oct 31, 2022

I can see you're trying to fix all of the onekey keymaps -- for now there's no need, just the analog would have sufficed for the context of this PR. It's great that the I2C ones are now sorted as well!

If you wish to create a followup PR in the future to fix others that's fine, but analog was really the only concern at this point. We'll generally check the failures and ignore them if they're unrelated to the PR's changes.

@itarze
Copy link
Contributor Author

itarze commented Oct 31, 2022

Can I handle all the onekey keymaps in this PR at once?

@tzarc
Copy link
Member

tzarc commented Oct 31, 2022

Can I handle all the onekey keymaps in this PR at once?

Sure, let me know when you're happy and I'll re-review.

@itarze
Copy link
Contributor Author

itarze commented Oct 31, 2022

@tzarc All the work items have been passed, you can review them now.

@tzarc tzarc merged commit 9435ad1 into qmk:develop Nov 1, 2022
@itarze itarze deleted the analog branch November 17, 2022 02:53
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Co-authored-by: Joy <chang.li@westberrytech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants