[Core] remove busy waiting from rgblight functions #18418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
approved these changes
Sep 19, 2022
fauxpark
reviewed
Sep 19, 2022
...these have presumably been added to guarantee ws2812 leds being reset properly, but this is already handled by the low level ws2812 drivers. Therefore we remove these waits to not block the main thread.
KarlK90
force-pushed
the
fix/remove-busy-waiting-from-rgblight
branch
from
f54ca64
to
3f71914
Compare
|
removed the |
14 tasks
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove busy waiting from rgblight functions these have presumably been added to guarantee ws2812 leds being reset properly, but this is already handled by the low level ws2812 drivers. Therefore we remove these waits to not block the main thread.
Types of Changes
Issues Fixed or Closed by This PR
Checklist