fix: mousekey doesn't work with trackpoint

[klesh]

Description

Related to #18277, I'm using cantor with trackpoint, so the mouse buttons are essential for, but they didn't seem to function correctly.

After some digging, I managed to solve the problem, and now the trackpoint and mousekeys are working perfectly for me. Might as well fix it for everyone.

Let me know if I missed anything. Thanks.

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Issues Fixed or Closed by This PR

• [Bug] Mouse Buttons Not Working When PS/2 is Enabled #18277

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[drashna]

This reverts the behavior that adding this function as is sought to fix, in the first place.

I'm guessing that this is for the ps2 trackpoint, correct?

[klesh]

@drashna Not really, I figured the should_mousekey_report_send function was meant to prevent sending unwanted reports to the host, however, the condition it was using detects only the movement, buttons state was omitted, so it should affect other use cases as well.

[klesh]

@drashna I've updated the code to handle the button state on top of existing logic. It should work for all cases, would you like to take a look when you have time, thanks

[drashna]

buttons are sent immediately usually, while motion isn't. Also, originally, the code was:
https://github.com/klesh/qmk_firmware/blob/5eb3fc255b0484062e720525202c7ba7d56779fe/quantum/mousekey.c#L254

[klesh]

@drashna Thanks for the quick response, I read the code, and found out:

1. https://github.com/qmk/qmk_firmware/blob/master/quantum/action.c#L524 shows that for PS2_MOUSE, it flips the tp_buttons state without sending it out immediately. Is it expected?
2. I failed to find the logic sending out the button events to the host in quantum/action.c, maybe this is the root cause of my symptom: click might work if I moved the cursor a little bit right before.

[drashna]

tp_buttons gets sent by ps2_mouse_task automatically (located in /drivers/ps2/ps2_mouse.c). And prior to the register_button function, it was handled in the same way. It was extracted to make it easier to handle.

Honestly, I'd like to integrate the ps2 code into the pointing device drivers, as this would reduce the number of edge cases like this.

[drashna]

Thinking about this, and some other code, I may have a more workable long term solution.

[klesh]

Thinking about this, and some other code, I may have a more workable long term solution.

This is great, I'm hesitating to work on a better solution since I don't know anything about the pointing device, nor do I have the device to test it out. Not to mention that I'm no expert on c language.

I would like to help if you need it, please let me know. You know, helping you to help myself 😃.

[klesh]

@drashna The error reported by the QMK CI Build doesn't seem to be caused by my PR? Would you mind taking a look at it? Thanks

[drashna]

QMK CI Build error is unrelated to the code change here. So you can ignore it.

[klesh]

Hi, @tzarc , would you mind taking another look at this PR? thanks.

[joh]

I have the same problem with my trackpoint using PS2 streaming mode. I can confirm that the changes in this PR fixes the problem for me as well.