Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup cradio bootloader/processor #18477

Merged
merged 2 commits into from
Sep 25, 2022
Merged

Fixup cradio bootloader/processor #18477

merged 2 commits into from
Sep 25, 2022

Conversation

waffle87
Copy link
Member

Description

As title

Types of Changes

  • Keyboard (addition or update)

Issues Fixed or Closed by This PR

tz ci

Compiling QMK Firmware for target: 'cradio:default'...

 * No bootloader specified. Please set an appropriate bootloader in your rules.mk or info.json.        [ERRORS]

platforms/avr/bootloader.mk:142: *** Invalid BOOTLOADER.  Stop.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team September 25, 2022 08:53
daskygit
daskygit requested changes Sep 25, 2022
View reviewed changes
keyboards/cradio/info.json Outdated Show resolved Hide resolved
@daskygit daskygit merged commit d84b1d1 into qmk:develop Sep 25, 2022
@waffle87 waffle87 deleted the fix/cradio branch September 25, 2022 17:57
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@waffle87 @ramonimbao
Fixup cradio bootloader/processor (qmk#18477)
eac1ae5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daskygit daskygit daskygit approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waffle87 @fauxpark @daskygit