Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Convert most of sinc to data driven info.json #18481

Merged
merged 2 commits into from
Sep 30, 2022
Merged

[Keyboard] Convert most of sinc to data driven info.json #18481

merged 2 commits into from
Sep 30, 2022

Conversation

SethBarberee
Copy link
Contributor

Description

Converted most of sinc to data driven config. I have a Rev1 so was able to test locally with my keymap. Not everything was converted because some stuff isn't 1:1 yet such as RGBLED_MAP and RGBLIGHT_DEFAULT_MODE

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team September 26, 2022 05:25
fauxpark
fauxpark requested changes Sep 26, 2022
View reviewed changes
@drashna drashna merged commit 26c3e87 into qmk:master Sep 30, 2022
@SethBarberee SethBarberee deleted the sinc_data_driven branch September 30, 2022 17:56
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 2, 2022
@SethBarberee @tacahiroy
[Keyboard] Convert most of sinc to data driven info.json (qmk#18481)
8c1c96e
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@SethBarberee
[Keyboard] Convert most of sinc to data driven info.json (qmk#18481)
16d1aaa
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@SethBarberee @ramonimbao
[Keyboard] Convert most of sinc to data driven info.json (qmk#18481)
1ddd1fe
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@SethBarberee @nolanseaton
[Keyboard] Convert most of sinc to data driven info.json (qmk#18481)
1d79fb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SethBarberee @drashna @fauxpark