Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ScottoCMD Keyboard #18520

Merged
merged 3 commits into from
Sep 29, 2022
Merged

Add ScottoCMD Keyboard #18520

merged 3 commits into from
Sep 29, 2022

Conversation

joe-scotto
Copy link
Contributor

Description

Add the ScottoCMD keyboard and default keymap.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team September 29, 2022 01:32
@drashna
Copy link
Member

drashna commented Sep 29, 2022

Also, ideally, the oled code should be moved to the kb level, that way, a default behavior is specified but can be overridden. This especially benefits QMK Configurator users.

@joe-scotto
Copy link
Contributor Author

@drashna I put the OLED code in the default keymap because it relies on the layers there.

@drashna drashna merged commit 43e57ab into qmk:master Sep 29, 2022
@joe-scotto joe-scotto deleted the scottocmd branch September 29, 2022 20:35
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 2, 2022
@joe-scotto @tacahiroy
[Keyboard] Add ScottoCMD Keyboard (qmk#18520)
bdd6f72
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@joe-scotto
[Keyboard] Add ScottoCMD Keyboard (qmk#18520)
0c921a3
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@joe-scotto @ramonimbao
[Keyboard] Add ScottoCMD Keyboard (qmk#18520)
dd93aa4
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@joe-scotto @nolanseaton
[Keyboard] Add ScottoCMD Keyboard (qmk#18520)
6d4320f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joe-scotto @drashna @fauxpark