Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[keyboard] tau4 fixup/refactor #18523

Merged
merged 6 commits into from
Sep 30, 2022
Merged

[keyboard] tau4 fixup/refactor #18523

merged 6 commits into from
Sep 30, 2022

Conversation

lesshonor
Copy link
Contributor

Description

  • Migrates settings to data-driven configuration where possible
    • This fixes the current (incorrect) display in Configurator and eliminates the #define RGB_ANIMATIONS warning
  • Adds encoder mapping, and migrates encoder + OLED declarations/callbacks to keyboard-level so firmware generated by QMK Configurator will have these features
  • Enables mousekeys, again so firmware generated by QMK Configurator can use them
  • Updates readme per current standards

I don't own this keyboard, but I have tested these changes to the best of my ability sans completely identical hardware. qmk info -kb tau4 -f text returns identical configuration where it is most important (matrix pins, diode direction, etc)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

tau4

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team September 29, 2022 03:35
@drashna drashna merged commit 1dd15a8 into qmk:master Sep 30, 2022
@lesshonor lesshonor deleted the tau4-fix-p1 branch September 30, 2022 00:18
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 2, 2022
@lesshonor @tacahiroy
[Keyboard] tau4 fixup/refactor (qmk#18523)
b044164
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@lesshonor
[Keyboard] tau4 fixup/refactor (qmk#18523)
8919059
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@lesshonor @ramonimbao
[Keyboard] tau4 fixup/refactor (qmk#18523)
6008b98
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@lesshonor @nolanseaton
[Keyboard] tau4 fixup/refactor (qmk#18523)
5ce159a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lesshonor @drashna @fauxpark @zvecr