Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup dimple/staggered/rev3 #18542

Closed
wants to merge 1 commit into from
Closed

Fixup dimple/staggered/rev3 #18542

wants to merge 1 commit into from

Conversation

waffle87
Copy link
Member

Description

Don't see any need for a dedicated rev3/keymaps/..., and default keymap uses LAYOUT, not LAYOUT_all.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team September 30, 2022 00:36
@fauxpark
Copy link
Member

fauxpark commented Sep 30, 2022 •
edited
Loading

LAYOUT_all should be used here because rev3 supports more than one layout. The build failures for this board should be fixed by #18449.

@waffle87
Copy link
Member Author

Ah that makes sense — closing.

@waffle87 waffle87 closed this Sep 30, 2022
@waffle87 waffle87 deleted the fix/dimple_rev3 branch September 30, 2022 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waffle87 @fauxpark @drashna