Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup linworks/fave84h #18593

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Fixup linworks/fave84h #18593

merged 1 commit into from
Oct 5, 2022

Conversation

waffle87
Copy link
Member

@waffle87 waffle87 commented Oct 5, 2022

Description

LAYOUT doesn't exist. Seems like #18450's branch did not catch #18496's changes.

Types of Changes

  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Oct 5, 2022
@fauxpark fauxpark requested a review from a team October 5, 2022 00:24
@zvecr zvecr merged commit b3211c1 into qmk:develop Oct 5, 2022
@waffle87 waffle87 deleted the fix/fave84h branch October 5, 2022 00:40
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@waffle87 @ramonimbao
Fixup linworks/fave84h (qmk#18593)
170f6bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waffle87 @fauxpark @zvecr