Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keymap] update andrebrait GMMK Pro keymap #18608

Merged
merged 4 commits into from
Oct 7, 2022

Conversation

andrebrait
Copy link
Contributor

Description

Updating my own keymap with the following changes:

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the keymap label Oct 5, 2022
@andrebrait andrebrait changed the title Keymap/andrebrait [Keymap] update andrebrait GMMK Pro keymap Oct 5, 2022
@drashna
Copy link
Member

drashna commented Oct 7, 2022

Fix a missing return value introduced with Fix Per Key LED Indicator Callbacks

Sorry about that, thought I got all of them!

@drashna drashna requested a review from a team October 7, 2022 05:35
@andrebrait
Copy link
Contributor Author

Fix a missing return value introduced with Fix Per Key LED Indicator Callbacks

Sorry about that, thought I got all of them!

No problem, but I haven't checked the other keymaps which copied from my code. They might still have missing values for the return. @drashna I'll try to get to it later.

@drashna drashna merged commit 150572d into qmk:develop Oct 7, 2022
@andrebrait andrebrait deleted the keymap/andrebrait branch November 25, 2022 15:47
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants