Fix MIDI output endpoint to use the out direction #18654
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug: cannot send MIDI messages to keyboard. The callback functions registered via midi_register_* are never invoked. This blocks implementing things like MIDI controller feedback where DAW software sends messages to the controller to turn indicator lights on/off etc.
Fix: update the endpoint direction to match the stream direction for MIDI output in lufa.c. The IN/OUT mismatch was introduced in f209f91, likely a copypaste error.
Note that I don't actually understand how this works :), the fix came from reviewing code and applying common sense. I did validate in a custom keyboard that this change unblocks sending MIDI notes to the keyboard and receiving them via midi_register_noteon_callback.
Types of Changes
Issues Fixed or Closed by This PR
Checklist