Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new keyboard definition: Daskeyboard4 #18675

Merged
merged 45 commits into from
Nov 30, 2022
Merged

new keyboard definition: Daskeyboard4 #18675

merged 45 commits into from
Nov 30, 2022

Conversation

Commander1024
Copy link
Contributor

Description

Added a keyboard definition for the commercial "daskeyboard 4 (Pro)" keyboard by Metadot. I replaced the original MCU/control board with a generic QMK enabled STM32 to restore functionaliry. Reverse engineered the original PCB. Handwired rotary encoeder / LEDs.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Commander1024 and others added 30 commits October 3, 2022 18:29
@Commander1024
Created new keyboard definition for 'daskeyboard 4 Pro', based on ful…
0cc7495 
…lsize_iso.
@Commander1024
Renamed keyboard (and switched to stm32 platform).
5a46c85
@Commander1024
Defined STM32 pins
95538a7
@Commander1024
Corrected pin names.
b963ea8
@Commander1024
Initial version of keymap. (Contains at least 1 error)
7b5a95b
@Commander1024
Fixed matrix error on K0C/ key 2
74c11c9
@Commander1024
Fixed typo.
15428ba
@Commander1024
Moved the keyboard into a subfolder, to allow for other keyboards of …
e007148 
…same brand.
@Commander1024
Moved the keyboard into a subfolder, to allow for other keyboards of …
562759c 
…same brand.
@Commander1024
Added (meta) information.
95b0028
@Commander1024
Merge branch 'qmk:master' into daskeyboard4
76fb5ba
@Commander1024
Removed duplicate url, fixed imgur hotlinks.
9238868
@Commander1024
Merge branch 'daskeyboard4' of github.com:Commander1024/qmk_firmware …
e1eb98b 
…into daskeyboard4
@Commander1024
Added labels additionally to matrix codes to info.json
8dbe5de
@Commander1024
Reassigned pins to the blackpill.
81be292
@Commander1024
Reassigned pins to the blackpill.
08602ed
@Commander1024
Changed to tinyuf2 bootloader.
be55a18
@Commander1024
Defined board type to account for the 25MH oscillator.
aec2327
@Commander1024
Fixed diode directin and moved pin A9 to B15.
3347294
@Commander1024
Changed bootmagic lite to ESC key (custom PCB)
3747b46
@Commander1024
Minor fixes. Added PCB pinout.
7b3a311
@Commander1024
Added LED indicators, rotary encoder for volume and scrolling, pinout…
14585fe 
… description and readme improvements.
@Commander1024
Added media keys to adjacent keys on layer 1 (_MEDIA) and inverted sc…
e7905f0 
…roll direction.
@Commander1024
Changed layer switch tapping to 2.
483c7f2
@Commander1024
Added mediakey mapping and description of _MEDIA layer.
a9787f3
@Commander1024
Moved as many configure options from config.h to info.json as possible.
ef89270
@Commander1024
Fixed NumLK and CAPS_LK LEDs.
1acde54
@Commander1024
Changed USB VID/PID to reflect the original ones.
f35299f
@Commander1024
QMK wants uppercase USB VID:PID.
0bf0e8c
@Commander1024
Merge branch 'qmk:master' into daskeyboard4
d686828
@Commander1024
Copy link
Contributor Author

Needs to be moved to the keyboards/handwired/ folder

Is there anything missing from my side?

Commander1024 and others added 3 commits October 16, 2022 12:00
@Commander1024 @drashna
Update keyboards/handwired/daskeyboard/daskeyboard4/readme.md
48090ac 
Smaller hotlink images

Co-authored-by: Drashna Jaelre <drashna@live.com>
@Commander1024
Added License information for keymap
395a839
@Commander1024 @drashna
Update keyboards/handwired/daskeyboard/daskeyboard4/keymaps/default/k…
f413816 
…eymap.c

Co-authored-by: Drashna Jaelre <drashna@live.com>
@Commander1024 @drashna
Update keyboards/handwired/daskeyboard/daskeyboard4/daskeyboard4.c
2cf7075 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Commander1024 and others added 2 commits November 16, 2022 15:35
@Commander1024 @drashna
Update keyboards/handwired/daskeyboard/daskeyboard4/daskeyboard4.c
609e349 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@Commander1024 @drashna
Update keyboards/handwired/daskeyboard/daskeyboard4/daskeyboard4.c
f913946 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna drashna requested a review from a team November 20, 2022 05:24
@Commander1024 @fauxpark
Update keyboards/handwired/daskeyboard/daskeyboard4/readme.md
fcdb04b 
Text formatting

Co-authored-by: Ryan <fauxpark@gmail.com>
@drashna drashna merged commit 402d3d8 into qmk:master Nov 30, 2022
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@Commander1024 @drashna
@fauxpark @elpekenin
[Keyboard] Daskeyboard4 (qmk#18675)
76ffa4a 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@Commander1024 @drashna
@fauxpark @crembz
[Keyboard] Daskeyboard4 (qmk#18675)
16405bd 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
sbhal pushed a commit to sbhal/qmk_firmware that referenced this pull request Dec 30, 2022
@Commander1024 @drashna @fauxpark
[Keyboard] Daskeyboard4 (qmk#18675)
cbc9500 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Glodigit pushed a commit to Glodigit/qmk_firmware that referenced this pull request Oct 18, 2023
@dlip
Merge remote-tracking branch 'upstream/master' into dlip
fff3805 
* upstream/master: (1776 commits)
  Fixup EFL and F4's sector selection. (qmk#19221)
  Fix `RGB_MATRIX_LED_COUNT` for aurora/corne (qmk#19222)
  [Keyboard] Fix config error for Charybdis (qmk#19219)
  [Keyboard] Add keyboard Caticorn (qmk#19138)
  Add meow48 ver.1.0 keyboard (qmk#19217)
  [Keyboard] Daskeyboard4 (qmk#18675)
  Update OLED doc (qmk#19213)
  [Keyboard] Add Litl keyboard (qmk#19000)
  [Keymap] Fixed ifohancroft Swap Hands Config (qmk#19176)
  Keeb.io Sinc: Enable Split LED state (qmk#19187)
  [Keymap] Update Miryoku (qmk#19190)
  Ignore some layout macro names from lint (qmk#19207)
  Add some community layouts to 40percentclub boards (qmk#19209)
  Add ortho_3x3 community layout (qmk#19210)
  Add missing default_ortho_5x5 keymap (qmk#19208)
  Fix bad bootmagic config (qmk#19206)
  Extend layout lint checks (qmk#19200)
  Fix headers in info.json reference (qmk#19202)
  Enable bootmagic (qmk#19191)
  [Keymap] Drashna updates for 0.19 (qmk#19175)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@keyboard-magpie keyboard-magpie keyboard-magpie approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Commander1024 @drashna @fauxpark @zvecr @keyboard-magpie