Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hubble keyboard #18718

Merged
merged 6 commits into from
Oct 31, 2022
Merged

Add Hubble keyboard #18718

merged 6 commits into from
Oct 31, 2022

Conversation

ch3rny
Copy link
Contributor

@ch3rny ch3rny commented Oct 14, 2022 •
edited
Loading

Description

Add Hubble PCB to QMK

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 14, 2022
drashna
drashna requested changes Oct 14, 2022
View reviewed changes
keyboards/hubble/hubble.c Outdated Show resolved Hide resolved
keyboards/hubble/hubble.h Outdated Show resolved Hide resolved
keyboards/hubble/info.json Outdated Show resolved Hide resolved
keyboards/hubble/info.json Outdated Show resolved Hide resolved
keyboards/hubble/info.json Outdated Show resolved Hide resolved
keyboards/hubble/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/hubble/keymaps/via/keymap.c Show resolved Hide resolved
keyboards/hubble/readme.md Outdated Show resolved Hide resolved
keyboards/hubble/rules.mk Outdated Show resolved Hide resolved
keyboards/hubble/info.json Outdated Show resolved Hide resolved
@ch3rny ch3rny requested a review from drashna October 14, 2022 20:12
zvecr
zvecr requested changes Oct 22, 2022
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also,
keyboards/hubble/rules.mk should match data/templates/keyboard/rules.mk

keyboards/hubble/config.h Outdated Show resolved Hide resolved
keyboards/hubble/readme.md Outdated Show resolved Hide resolved
@ch3rny ch3rny requested review from zvecr and drashna and removed request for drashna and zvecr October 23, 2022 07:44
drashna
drashna reviewed Oct 25, 2022
View reviewed changes
keyboards/hubble/readme.md Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team October 27, 2022 00:18
@drashna drashna merged commit 652b10e into qmk:master Oct 31, 2022
@ch3rny ch3rny mentioned this pull request Oct 31, 2022
Merged
6 tasks
@ch3rny ch3rny deleted the hubble branch October 31, 2022 11:37
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@ch3rny
[Keyboard] Add Hubble keyboard (qmk#18718)
5324abb 
Co-authored-by: Anton Chernenko <anton.chernenko@chaintrust.it>
thystips pushed a commit to thystips/qmk_firmware that referenced this pull request Nov 24, 2022
@ch3rny @thystips
[Keyboard] Add Hubble keyboard (qmk#18718)
f2fee76 
Co-authored-by: Anton Chernenko <anton.chernenko@chaintrust.it>
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@ch3rny @ramonimbao
[Keyboard] Add Hubble keyboard (qmk#18718)
f1aeb4f 
Co-authored-by: Anton Chernenko <anton.chernenko@chaintrust.it>
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@ch3rny @nolanseaton
[Keyboard] Add Hubble keyboard (qmk#18718)
ad42eb7 
Co-authored-by: Anton Chernenko <anton.chernenko@chaintrust.it>
ChrisChrisLoLo pushed a commit to ChrisChrisLoLo/qmk_firmware that referenced this pull request Sep 2, 2023
@ch3rny @ChrisChrisLoLo
[Keyboard] Add Hubble keyboard (qmk#18718)
e55f82a 
Co-authored-by: Anton Chernenko <anton.chernenko@chaintrust.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ch3rny @drashna @fauxpark @zvecr