Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quantum/audio from global VPATH #18753

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Oct 17, 2022

Description

Ideally should only be needed if AUDIO_ENABLE = yes.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark marked this pull request as ready for review October 18, 2022 02:34
@zvecr zvecr merged commit af67852 into qmk:develop Oct 20, 2022
@fauxpark fauxpark deleted the remove-global-audio-vpath branch October 20, 2022 13:42
fauxpark added a commit to fauxpark/qmk_firmware that referenced this pull request Oct 20, 2022
tzarc pushed a commit that referenced this pull request Oct 20, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants