Fix #156: clear weak mods on every key press #188
Conversation
- new macro_mods bit field for mods applied by macros
- weak_mods now only used for ACT_{L,R}MODS (i.e. LSFT, RSFT, LCTL etc.)
- clear the _weak_ mods on every key *pressed* such that LSFT etc.
can no more interfere with the next key
|
@Eric-L-T TBH I don't really get why you are holding your contribution if you have already tested it sufficiently. I'm not following the OLKB news – I'm an ErgoDox EZ user – but as I understand it the delay for OLKB is 3-8 weeks, right? I really need a fix for #156 for my everyday usage and I'd prefer to have one in Jack's repository so that I can contribute layouts that rely on it. For the moment I can't even be sure that your solution will actually be merged – or even whether it actually fixes #156 for my use case. p.s.: I'm replying directly on the PR so that people watching Jack's repo also get notifications |
|
I like this solution - I'll try to do some testing soon :) |
|
@Eric-L-T This fix clears the weak mods on every key press, such that the mods applied by However simply clearing the weak mods without using a different bit field for macros would obviously affect the macros too, and some people might be using macros to intentionally apply modifiers so I don't want to change this behaviour. |
|
@jackhumbert - wanna merge this one? |
|
I'd like to, but I haven't had the chance to double-check things yet - if it looks ok to you, let's get it merged! |
|
Let's do it! Living dangerously here. Can always revert with the power of git. @DidierLoiseau here we go! |
|
Thanks :-) |
on mod keys, register LGUI, LSFT etc. as normal mods instead of weak mods: - they won't be cleared when pressing another key (qmk#188) - they won't be cleared by layer switching - LSFT(KC_LGUI) will now have the same behavior as LGUI(KC_LSFT)
|
@DidierLoiseau Jack has given me the go-ahead. One pull request coming up! |
Fix for #156:
macro_modsbit field for mods applied by macros – implementation is exactly the same asweak_modsused to be;weak_modsis now only used forACT_{L,R}MODS(i.e.LSFT,RSFT,LCTLetc.);weak_modson every key pressed such thatLSFTetc. can no more interfere with the next key.