-
-
Notifications
You must be signed in to change notification settings - Fork 39.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[keyboard]Add Graystudio Space65 R3 #18909
Conversation
@drashna Hi, can you give me some help? I have trouble finding the error. The files compile perfectly on my end. |
@drashna I am still having problems with the lighting. Can you help me out on this one? |
It looks like the only issues are the mechmerlin and spidey3 keymaps are not compiling. These are likely community layouts, so they can be safely ignored. The other keymaps compile file. Eg: |
_______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, | ||
_______, _______, _______, _______, _______, _______, _______, _______, _______ | ||
), | ||
[4] = LAYOUT( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default is 4 layers. If it supports more than that, the dynamic keymap define should be changed to support 8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are those empty layers actually required after #17695 (already in master)?
Co-authored-by: Drashna Jaelre <drashna@live.com>
…/qmk_firmware into gray_studio-space65r3
Should I just simply ignore it? If so I have fixed other issues. |
Yes. However, there are some other changes needed now. |
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Thanks a lot! I have committed to the changes. |
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Description
Add Space65R3
Types of Changes
Checklist