Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keyboard]Add Graystudio Space65 R3 #18909

Merged
merged 29 commits into from
Dec 30, 2022
Merged

Conversation

edwardslau
Copy link
Contributor

@edwardslau edwardslau commented Oct 30, 2022

Description

Add Space65R3

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 30, 2022
@edwardslau
Copy link
Contributor Author

@drashna Hi, can you give me some help? I have trouble finding the error. The files compile perfectly on my end.

keyboards/gray_studio/space65r3/config.h Outdated Show resolved Hide resolved
keyboards/gray_studio/space65r3/config.h Outdated Show resolved Hide resolved
keyboards/gray_studio/space65r3/config.h Outdated Show resolved Hide resolved
keyboards/gray_studio/space65r3/info.json Outdated Show resolved Hide resolved
keyboards/gray_studio/space65r3/halconf.h Outdated Show resolved Hide resolved
keyboards/gray_studio/space65r3/rules.mk Outdated Show resolved Hide resolved
keyboards/gray_studio/space65r3/rules.mk Outdated Show resolved Hide resolved
keyboards/gray_studio/space65r3/space65r3.c Outdated Show resolved Hide resolved
keyboards/gray_studio/space65r3/space65r3.h Outdated Show resolved Hide resolved
@edwardslau
Copy link
Contributor Author

@drashna I am still having problems with the lighting. Can you help me out on this one?

@drashna
Copy link
Member

drashna commented Nov 20, 2022

@drashna I am still having problems with the lighting. Can you help me out on this one?

It looks like the only issues are the mechmerlin and spidey3 keymaps are not compiling. These are likely community layouts, so they can be safely ignored. The other keymaps compile file.

Eg:
https://github.com/qmk/qmk_firmware/pull/18909/checks?check_run_id=9588958570

keyboards/gray_studio/space65r3/config.h Outdated Show resolved Hide resolved
_______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______,
_______, _______, _______, _______, _______, _______, _______, _______, _______
),
[4] = LAYOUT(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is 4 layers. If it supports more than that, the dynamic keymap define should be changed to support 8.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those empty layers actually required after #17695 (already in master)?

@edwardslau
Copy link
Contributor Author

@drashna I am still having problems with the lighting. Can you help me out on this one?

It looks like the only issues are the mechmerlin and spidey3 keymaps are not compiling. These are likely community layouts, so they can be safely ignored. The other keymaps compile file.

Eg: https://github.com/qmk/qmk_firmware/pull/18909/checks?check_run_id=9588958570

Should I just simply ignore it? If so I have fixed other issues.

@drashna
Copy link
Member

drashna commented Nov 30, 2022

@drashna I am still having problems with the lighting. Can you help me out on this one?

It looks like the only issues are the mechmerlin and spidey3 keymaps are not compiling. These are likely community layouts, so they can be safely ignored. The other keymaps compile file.
Eg: https://github.com/qmk/qmk_firmware/pull/18909/checks?check_run_id=9588958570

Should I just simply ignore it? If so I have fixed other issues.

Yes.

However, there are some other changes needed now.

edwardslau and others added 2 commits November 30, 2022 11:51
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
@edwardslau
Copy link
Contributor Author

@drashna I am still having problems with the lighting. Can you help me out on this one?

It looks like the only issues are the mechmerlin and spidey3 keymaps are not compiling. These are likely community layouts, so they can be safely ignored. The other keymaps compile file.
Eg: https://github.com/qmk/qmk_firmware/pull/18909/checks?check_run_id=9588958570

Should I just simply ignore it? If so I have fixed other issues.

Yes.

However, there are some other changes needed now.

Thanks a lot! I have committed to the changes.

edwardslau and others added 3 commits November 30, 2022 12:19
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
keyboards/gray_studio/space65r3/config.h Outdated Show resolved Hide resolved
@tzarc tzarc merged commit 590c889 into qmk:master Dec 30, 2022
sbhal pushed a commit to sbhal/qmk_firmware that referenced this pull request Dec 30, 2022
Co-authored-by: Drashna Jaelre <drashna@live.com>
jasonisgraham pushed a commit to jasonisgraham/qmk_firmware that referenced this pull request Jan 2, 2023
Co-authored-by: Drashna Jaelre <drashna@live.com>
@lowerworld lowerworld mentioned this pull request Jan 11, 2023
6 tasks
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
Co-authored-by: Drashna Jaelre <drashna@live.com>
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
Co-authored-by: Drashna Jaelre <drashna@live.com>
jasonisgraham pushed a commit to jasonisgraham/qmk_firmware that referenced this pull request Jun 12, 2023
Co-authored-by: Drashna Jaelre <drashna@live.com>
jasonisgraham pushed a commit to jasonisgraham/qmk_firmware that referenced this pull request Jun 15, 2023
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants