Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Add support for KBDfans Odin V2 #18910

Merged
merged 2 commits into from
Nov 20, 2022
Merged

Conversation

lexbrugman
Copy link
Contributor

@lexbrugman lexbrugman commented Oct 30, 2022

Description

Adding support for the KBDfans Odin V2

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 30, 2022
@lexbrugman lexbrugman changed the title Add support for KBDfans Odin V2 [Keyboard] Add support for KBDfans Odin V2 Oct 31, 2022
@drashna drashna requested a review from a team November 19, 2022 19:48
@drashna drashna merged commit 66e4add into qmk:develop Nov 20, 2022
@lexbrugman lexbrugman deleted the odin-v2 branch November 20, 2022 08:43
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@lesshonor
Copy link
Contributor

lesshonor commented Mar 12, 2023

This PR uses PID 0x0101, which is the same as for the Odin Soldered. This in turn causes all tools, e.g. VIA to not function, as the Odin Soldered does not have RGB. Any special reason the same PID was used here ?

...Probably so the same matrix definitions would be re-used. The docs encourage this:

Note that multiple versions/revisions of a keyboard PCB can use the same vendor/product if they function the same from VIA Configurator’s point of view, i.e. they have the same (or compatible) physical key layout and switch matrix topology and the same “layout macro” (mapping physical key layout to switch matrix layout) is used. VIA Configurator doesn’t care which I/O pins are being used, it just reads/writes keycodes to the dynamic keymaps stored in switch matrix addressing. As such, please consider carefully whether you actually need to create more than one vendor/product ID pair for multiple versions of the same keyboard PCB.

As far as I'm aware, there's no documentation indicating that unique product IDs are required for different lighting implementations...perhaps because until recently VIA didn't care whether the "lighting" definition of a board matched its firmware implementation. (On a lot of DIY boards, adding lighting is up to the end-user...) Board owners without it could simply ignore the Lighting tab, and a lot of boards that use RGB_MATRIX just went with RGBLIGHT since VIA didn't support the former.

FWIW, I don't think Vial or Remap have this issue, so if you're in a pinch and have older firmware handy, you could try using one of those remappers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants