Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support keyboard Pila87 / XM87 PRO #18919

Merged
merged 5 commits into from
Dec 30, 2022
Merged

Added support keyboard Pila87 / XM87 PRO #18919

merged 5 commits into from
Dec 30, 2022

Conversation

HorrorTroll
Copy link
Contributor

Description

Added support keyboard Pila87 / XM87 PRO

Ping @Pangorin

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 31, 2022
Pangorin
Pangorin approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@Pangorin Pangorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix

keyboards/phage_studio/pila87/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/phage_studio/pila87/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team November 8, 2022 08:09
@HorrorTroll HorrorTroll changed the base branch from master to develop November 9, 2022 06:25
@drashna drashna changed the base branch from develop to master November 28, 2022 01:01
@tzarc tzarc merged commit 5fa2aab into qmk:master Dec 30, 2022
sbhal pushed a commit to sbhal/qmk_firmware that referenced this pull request Dec 30, 2022
@HorrorTroll
Added support keyboard Pila87 / XM87 PRO (qmk#18919)
2469f99
jasonisgraham pushed a commit to jasonisgraham/qmk_firmware that referenced this pull request Jan 2, 2023
@HorrorTroll @jasonisgraham
Added support keyboard Pila87 / XM87 PRO (qmk#18919)
93c51c7
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@HorrorTroll @omikronik
Added support keyboard Pila87 / XM87 PRO (qmk#18919)
ff284d5
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
@HorrorTroll @ideas32
Added support keyboard Pila87 / XM87 PRO (qmk#18919)
6c054f3
@HorrorTroll HorrorTroll deleted the pila87 branch March 16, 2023 08:36
jasonisgraham pushed a commit to jasonisgraham/qmk_firmware that referenced this pull request Jun 12, 2023
@HorrorTroll @jasonisgraham
Added support keyboard Pila87 / XM87 PRO (qmk#18919)
4793aec
jasonisgraham pushed a commit to jasonisgraham/qmk_firmware that referenced this pull request Jun 15, 2023
@HorrorTroll @jasonisgraham
Added support keyboard Pila87 / XM87 PRO (qmk#18919)
96eabc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pangorin Pangorin Pangorin approved these changes

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HorrorTroll @drashna @tzarc @Pangorin