Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[update] change RGBLED_NUM to 20 for zoom87 #18930

Merged
merged 4 commits into from
Nov 20, 2022
Merged

[update] change RGBLED_NUM to 20 for zoom87 #18930

merged 4 commits into from
Nov 20, 2022

Conversation

spbgzh
Copy link
Contributor

@spbgzh spbgzh commented Nov 1, 2022

Description

change RGBLED_NUM to 20

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

#17831

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@spbgzh spbgzh changed the title [Add Function] change RGBLED_NUM to 20 for zoom87 [Fix] change RGBLED_NUM to 20 for zoom87 Nov 1, 2022
@spbgzh spbgzh changed the title [Fix] change RGBLED_NUM to 20 for zoom87 [update] change RGBLED_NUM to 20 for zoom87 Nov 1, 2022
@spbgzh spbgzh marked this pull request as draft November 6, 2022 18:46
@spbgzh spbgzh marked this pull request as ready for review November 6, 2022 18:48
@drashna drashna requested a review from a team November 19, 2022 20:28
@spbgzh spbgzh requested a review from drashna November 20, 2022 01:15
@drashna drashna merged commit 6216019 into qmk:master Nov 20, 2022
thystips pushed a commit to thystips/qmk_firmware that referenced this pull request Nov 24, 2022
@spbgzh @drashna @thystips
[Keyboard] change RGBLED_NUM to 20 for zoom87 (qmk#18930)
e554600 
Co-authored-by: Drashna Jaelre <drashna@live.com>
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@spbgzh @drashna @ramonimbao
[Keyboard] change RGBLED_NUM to 20 for zoom87 (qmk#18930)
c8d4489 
Co-authored-by: Drashna Jaelre <drashna@live.com>
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@spbgzh @drashna @elpekenin
[Keyboard] change RGBLED_NUM to 20 for zoom87 (qmk#18930)
414c2f6 
Co-authored-by: Drashna Jaelre <drashna@live.com>
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@spbgzh @drashna @crembz
[Keyboard] change RGBLED_NUM to 20 for zoom87 (qmk#18930)
1de0a37 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spbgzh @drashna @fauxpark