BT LEDs are no longer hard coded #18934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…key they are mapped to
drashna
approved these changes
Nov 12, 2022
fauxpark
approved these changes
Nov 13, 2022
sigprof
reviewed
Nov 16, 2022
Comment on lines
155
to
159
| case KC_AP2_BT1: | ||
| annepro2_ble_broadcast(0); | ||
| /* FIXME: This hardcodes col/row position */ | ||
| ap2_led_blink(0, 1, blue, 8, 50); | ||
| ap2_led_blink(record->event.key.row, record->event.key.col, blue, 8, 50); | ||
| return false; |
There was a problem hiding this comment.
Note that if someone decides to put KC_AP2_BT1 on a combo, record->event.key will contain {KEYLOC_COMBO, KEYLOC_COMBO} ({254, 254}) instead of real row and column numbers. If the LED firmware won't handle such out of range values correctly, you should add range checks somewhere.
And the FIXME can probably be removed too.
There was a problem hiding this comment.
I don't know too much about the way combo keys work, I will look into that when I can. Thanks
dkruyt
pushed a commit
to dkruyt/qmk_firmware
that referenced
this pull request
Nov 18, 2022
thystips
pushed a commit
to thystips/qmk_firmware
that referenced
this pull request
Nov 24, 2022
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
elpekenin
pushed a commit
to elpekenin/qmk_firmware
that referenced
this pull request
Dec 7, 2022
crembz
pushed a commit
to crembz/qmk_firmware
that referenced
this pull request
Dec 18, 2022
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The keyboard BT LEDs are no longer hard coded into the keyboard but will move according to the corresponding mapping of BT Key
Types of Changes
Issues Fixed or Closed by This PR
Checklist