Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "no matrix definition" errors for some boards #18954

Merged
merged 1 commit into from
Nov 5, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Nov 5, 2022

Description

☒ acheron/arctic: Layout "LAYOUT_60_ansi_tsangan" has no "matrix" definition in either "info.json" or "<keyboard>.h"!
☒ bpiphany/pegasushoof/2013: Layout "LAYOUT_tkl_iso" has no "matrix" definition in either "info.json" or "<keyboard>.h"!
☒ ergodox_stm32: Layout "LAYOUT_ergodox_80" has no "matrix" definition in either "info.json" or "<keyboard>.h"!
☒ ergodox_stm32: Layout "LAYOUT_ergodox_pretty_80" has no "matrix" definition in either "info.json" or "<keyboard>.h"!
☒ eyeohdesigns/babyv: Layout "LAYOUT_1u2u" has no "matrix" definition in either "info.json" or "<keyboard>.h"!
☒ eyeohdesigns/babyv: Layout "LAYOUT_2u1u" has no "matrix" definition in either "info.json" or "<keyboard>.h"!
☒ geekboards/macropad_v2: Layout "LAYOUT" has no "matrix" definition in either "info.json" or "<keyboard>.h"!
☒ handwired/fruity60: Layout "LAYOUT" has no "matrix" definition in either "info.json" or "<keyboard>.h"!
☒ handwired/swiftrax/bebol: Layout "LAYOUT" has no "matrix" definition in either "info.json" or "<keyboard>.h"!
☒ sneakbox/disarray/ortho: Layout "LAYOUT_all" has no "matrix" definition in either "info.json" or "<keyboard>.h"!
☒ spaceholdings/nebula12: Layout "LAYOUT_68_ansi" has no "matrix" definition in either "info.json" or "<keyboard>.h"!

acheron/arctic: LAYOUT_60_ansi_tsangan was missing. Since the design files are open source I verified the layout. It also appears the split right shift in the 60_tsangan_hhkb layout was swapped.
bpiphany/pegasushoof/2013: Seems like the 2013 revision does not support the ISO layout; if it does, might need some extra attention to determine the matrix. For now, I've moved the layouts from the root info.json.
ergodox_stm32: No idea what the matrix for these layouts are, and there are no keymaps using them. Removed from info.json.
eyeohdesigns/babyv: Missing _ in layout name.
geekboards/macropad_v2: Fixed info.json layout name to match macro and existing keymaps.
handwired/fruity60: Same.
handwired/swiftrax/bebol: Same.
sneakbox/disarray/ortho: Same.
spaceholdings/nebula12: Fixed incorrect layout names.

Still to do:

☒ cannonkeys/db60/hotswap: Layout "LAYOUT_60_iso" has no "matrix" definition in either "info.json" or "<keyboard>.h"!
☒ handwired/swiftrax/cowfish: Layout "LAYOUT_full_bs" has no "matrix" definition in either "info.json" or "<keyboard>.h"!

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added bug keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Nov 5, 2022
@fauxpark fauxpark requested a review from a team November 5, 2022 01:05
@fauxpark
Copy link
Member Author

fauxpark commented Nov 5, 2022

CI failures unrelated.

@zvecr zvecr merged commit 54682f9 into qmk:develop Nov 5, 2022
@fauxpark fauxpark deleted the fix-no-matrix-defs branch November 5, 2022 02:53
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants