Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro keycode name refactoring #18958

Merged
merged 6 commits into from
Nov 5, 2022
Merged

Macro keycode name refactoring #18958

merged 6 commits into from
Nov 5, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Nov 5, 2022

Description

As per the rest of the QMK-specific keycode changes.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested review from fauxpark, zvecr and a team November 5, 2022 11:09
@github-actions github-actions bot added cli qmk cli command core documentation keymap python via Adds via keymap and/or updates keyboard for via support labels Nov 5, 2022
@tzarc tzarc merged commit 4d33f35 into qmk:develop Nov 5, 2022
@tzarc tzarc deleted the macro_keycode_naming branch November 5, 2022 12:22
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@tzarc @ramonimbao
Macro keycode name refactoring (qmk#18958)
4abb1dc
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@tzarc @elpekenin
Macro keycode name refactoring (qmk#18958)
091d438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
cli qmk cli command core documentation keymap python translation via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzarc @fauxpark @zvecr