Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannonkeys/db60/hotswap: fix layouts #18982

Merged
merged 2 commits into from
Nov 7, 2022
Merged

cannonkeys/db60/hotswap: fix layouts #18982

merged 2 commits into from
Nov 7, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Nov 7, 2022 •
edited
Loading

Description

☒ cannonkeys/db60/hotswap: Layout "LAYOUT_60_iso" has no "matrix" definition in either "info.json" or "<keyboard>.h"!

Hotswap PCB does not support ISO layout: https://docs.cannonkeys.com/images/bakeneko/01-kit.jpeg

cc @awkannan

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team November 7, 2022 02:52
@fauxpark
Copy link
Member Author

fauxpark commented Nov 7, 2022

CI failures are unrelated. I went ahead and fixed the KC_SLCKs in the Miryoku userspace just to shut it up.

@tzarc tzarc merged commit 4deaa58 into qmk:develop Nov 7, 2022
@fauxpark fauxpark deleted the db60-hotswap-fix-layouts branch November 7, 2022 05:44
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@fauxpark @ramonimbao
cannonkeys/db60/hotswap: fix layouts (qmk#18982)
6a7e7eb
manna-harbour added a commit to manna-harbour/qmk_firmware that referenced this pull request Nov 29, 2022
@manna-harbour
[miryoku] Revert upstream changes to miryoku_layer_alternatives.h
c3530a5 
- `cannonkeys/db60/hotswap`: fix layouts (qmk#18982)
- Normalise output selection (Bluetooth) keycodes (qmk#19004)
hanifn pushed a commit to hanifn/qmk_firmware that referenced this pull request Dec 1, 2022
@manna-harbour
[miryoku] Revert upstream changes to miryoku_layer_alternatives.h
bf24975 
- `cannonkeys/db60/hotswap`: fix layouts (qmk#18982)
- Normalise output selection (Bluetooth) keycodes (qmk#19004)
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@fauxpark @elpekenin
cannonkeys/db60/hotswap: fix layouts (qmk#18982)
17525e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
bug keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @tzarc