Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kint36: do not restart USB stack after wakeup #19077

Merged
merged 1 commit into from
Dec 8, 2022
Merged

kint36: do not restart USB stack after wakeup #19077

merged 1 commit into from
Dec 8, 2022

Conversation

stapelberg
Copy link
Contributor

Without this change, the Teensy 3.6 kinT variant can wake a computer from Suspend-to-RAM, but the keyboard does not actually produce any keypresses until you un-plug and re-plug it.

related to kinx-project/kint#59

related to #16934

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Nov 14, 2022
@stapelberg
Copy link
Contributor Author

Created this as a draft pull request for now. I did a brief test of the functionality so far, but I want to test this change for a few more days to make sure it works well.

@stapelberg stapelberg mentioned this pull request Nov 14, 2022
Closed
@tzarc tzarc added the bug label Nov 14, 2022
@stapelberg stapelberg marked this pull request as ready for review November 17, 2022 07:45
@stapelberg
Copy link
Contributor Author

Marked this PR as ready for review. I have been using this on my primary keyboard for the last few days, with multiple successful suspend-to-ram/resume cycles.

Please take a look :)

@drashna drashna requested review from sigprof, tzarc and a team November 20, 2022 05:36
@fauxpark
Copy link
Member

IC stands for Input Club; the board name should not be changed.

@stapelberg
Copy link
Contributor Author

Oh, thanks for the explanation. I updated the PR to keep using the same board name. Please take another look.

@fauxpark
Copy link
Member

A rebase onto current master (actually this should go to develop) ought to fix the CI build.

@stapelberg stapelberg changed the base branch from master to develop November 20, 2022 12:43
@stapelberg
kint36: do not restart USB stack after wakeup
cc658bc 
Without this change, the Teensy 3.6 kinT variant can wake a computer from
Suspend-to-RAM, but the keyboard does not actually produce any keypresses until
you un-plug and re-plug it.

related to kinx-project/kint#59

related to qmk#16934
@stapelberg
Copy link
Contributor Author

Ah, I thought bugfixes go to master. Anyway, I rebased my PR onto latest develop.

Unfortunately CI still fails, but that seems unrelated to my change.

@stapelberg
Copy link
Contributor Author

All checks seem to pass. Please take another look?

@fauxpark
Copy link
Member

fauxpark commented Dec 6, 2022

I'd like to check whether this is applicable to 3.5 as well. Will try to do so tomorrow.

@stapelberg
Copy link
Contributor Author

That should probably be done in a separate pull request anyway to reduce the potential impact in case things go wrong (and make a revert easier, without impacting my change).

Can we merge this one independently of your tests?

fauxpark
fauxpark approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can repro on 3.5, fix works there too.

@stapelberg
Copy link
Contributor Author

Great! Can we merge the PR, then? :)

Thanks

@tzarc tzarc merged commit 9e103a2 into qmk:develop Dec 8, 2022
@stapelberg stapelberg deleted the wakeup-kint36 branch December 8, 2022 19:20
@fauxpark fauxpark mentioned this pull request Dec 9, 2022
Merged
14 tasks
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@stapelberg @omikronik
kint36: do not restart USB stack after wakeup (qmk#19077)
8070026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

@sigprof sigprof Awaiting requested review from sigprof

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stapelberg @fauxpark @tzarc